Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for Infinispan and rename property #1089

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants

@DavideD DavideD self-assigned this Oct 17, 2018

@DavideD DavideD requested a review from fax4ever Oct 17, 2018

@fax4ever
Copy link
Contributor

fax4ever left a comment

Thank you @DavideD nice job. This chapter has needed a proper review. I've just few questions, most of them are not critical.

@DavideD DavideD force-pushed the DavideD:OGM-1419 branch 2 times, most recently from 446ebdd to 2b2e417 Oct 17, 2018

@DavideD

This comment has been minimized.

Copy link
Member Author

DavideD commented Oct 17, 2018

Applied most of the remarks. It should be possible to merge it now

@gsmet
Copy link
Member

gsmet left a comment

Added 2 minor comments.

Note that, except when using [acronym]`JNDI`, Hibernate OGM will bootstrap and Infinispan Embedded node
in your same JVM, and terminate it on shutdown of the Hibernate instance.
Note that, except when using [acronym]`JNDI`, Hibernate OGM will bootstrap Infinispan Embedded
in the same JVM and terminate it on shutdown of the Hibernate OGM factory.

This comment has been minimized.

Copy link
@gsmet

gsmet Oct 17, 2018

Member

I think you mean session factory here? factory is a bit weird as it could be a factory of anything.

This comment has been minimized.

Copy link
@DavideD

DavideD Oct 17, 2018

Author Member

I will replace it with session factory

@@ -169,7 +169,7 @@ To add the dependencies for the Hibernate OGM extensions for Infinispan Embedded
</dependency>
----

If you're not using a dependency management tool,
If you're not using a dependencies management tool,

This comment has been minimized.

Copy link
@gsmet

gsmet Oct 17, 2018

Member

dependency was more correct here.

This comment has been minimized.

Copy link
@DavideD

DavideD Oct 17, 2018

Author Member

right

@DavideD DavideD force-pushed the DavideD:OGM-1419 branch from 2b2e417 to 137c4d1 Oct 17, 2018

OGM-1419 Update Infinispan documentation
  * Typos
  * Revisit cache configuration example
  * Byte is not supported for queries

@DavideD DavideD force-pushed the DavideD:OGM-1419 branch from 137c4d1 to ccc91d6 Oct 17, 2018

@DavideD

This comment has been minimized.

Copy link
Member Author

DavideD commented Oct 17, 2018

Updated

@fax4ever

This comment has been minimized.

Copy link
Contributor

fax4ever commented Oct 17, 2018

Merged #1089. Thank you

@fax4ever fax4ever closed this Oct 17, 2018

@DavideD

This comment has been minimized.

Copy link
Member Author

DavideD commented Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.