Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OGM-541 Caching translated JP-QL queries #345

Merged
merged 10 commits into from Jul 29, 2014

Conversation

Projects
None yet
3 participants
@gunnarmorling
Copy link
Member

gunnarmorling commented Jul 16, 2014

@emmanuelbernard, @DavideD: I'm not fully done yet, but could you guys take a quick look so we know whether we agree on the general strategy?

The idea is to implement ORM's QueryTranslator SPI. This gives us many benefits, not only the caching but also handling of polymorphic queries, (I think) proper auto-flushing of affected query spaces etc. I'm cheating a bit though by delegating many things to the existing parser, but I think it's a good strategy to subsequently reduce this delegation step by step. WDYT?

@emmanuelbernard

This comment has been minimized.

Copy link
Member

emmanuelbernard commented Jul 16, 2014

I don't understand the full ins and outs but it seems to go in the direction I had in mind.

@gunnarmorling

This comment has been minimized.

Copy link
Member Author

gunnarmorling commented Jul 28, 2014

Pushed an update. I think it's good to go now. Let me know what you think, especially @DavideD, as you haven't said anything yet :)

@DavideD

This comment has been minimized.

Copy link
Member

DavideD commented Jul 29, 2014

It seems we can include this and move on. Could you rebase this to the latest changes? There are a few small conflicts

@gunnarmorling

This comment has been minimized.

Copy link
Member Author

gunnarmorling commented Jul 29, 2014

Rebased and added another commit with a temporary solution for caching queries in the case parameterized queries are not supported natively.

@DavideD DavideD merged commit a2c4db1 into hibernate:master Jul 29, 2014

1 check passed

default Merged build finished.
Details
@DavideD

This comment has been minimized.

Copy link
Member

DavideD commented Jul 29, 2014

Merged #345

Thanks!

@gunnarmorling gunnarmorling deleted the gunnarmorling:OGM-541 branch Jul 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.