Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
OGM-650 Contrib repository #850
gsmet left a comment
I added a few comments and questions but it looks good overall.
It misses some doc about the contrib modules in the main doc and in the README.md but I suppose you were planning on adding that once the dust is settled and the contrib repository moved under the hibernate organization.
I have 3 major questions/remarks about the contrib modules:
OK, It makes sense. I see what I can do.
I'm open to other solutions but I think I prefer to have a way for each dialect to skip it's own tests.
it should fail only if the person changed something affecting the other modules. It's a good idea anyway.
Yeah, my guess is that when we will make an infrastructure change to the core, the contrib dialects won't be adapted right away so some may fail for some time. Having Travis for the one you work on even in this case looks like a good idea to me.
We are removing from the documentation, integrationt tests and wildfly modules the following: * Cassandra * Redis * CouchDB * EhCache We are moving them in a separate repository for contributed dialects.
Tests for Cassandra, CouchDB, Redis and Ehcache won't be run anymore. It's now responsability of the contrib repository to execute this tests.
Contributors can use it to run integration tests on dialects that are not in the main repository
Looks good. Logging things we should not forget about: update the README.md, clean up the .travis.yml file (there are Redis and Cassandra specific stuff in it).
I'm wondering if we should consider changing the groupId in the contrib repo to org.hibernate.ogm.contrib (not sure it's recommended to use a subgroup or if we have to use something like org.hibernate.ogm-contrib). WDYT? It's probably something we should discuss with the others.
I think it's probably worth a general email on the list to check that we're all on the same page before merging this.
I've added a commit to move some properties in the BOM so that they are consistent in the new repositories. The repository for CouchDB, Cassandra, EhCache and Redis are currently on my account but I'll create them in the hibernate one if they are OK:
They will need some additional work in regard to the documentation and possibly something else but I think they are a good starting point.