From 580a71331cc07b1b56308559c7242395a9b8c0d6 Mon Sep 17 00:00:00 2001 From: Brett Meyer Date: Thu, 1 Aug 2013 14:42:47 -0400 Subject: [PATCH] HHH-8390 generate FK after UK --- .../java/org/hibernate/cfg/Configuration.java | 51 +++++++++++++------ 1 file changed, 36 insertions(+), 15 deletions(-) diff --git a/hibernate-core/src/main/java/org/hibernate/cfg/Configuration.java b/hibernate-core/src/main/java/org/hibernate/cfg/Configuration.java index 1b9a9954f507..bcad9ec483ec 100644 --- a/hibernate-core/src/main/java/org/hibernate/cfg/Configuration.java +++ b/hibernate-core/src/main/java/org/hibernate/cfg/Configuration.java @@ -1092,9 +1092,17 @@ public String[] generateSchemaCreationScript(Dialect dialect) throws HibernateEx ) ); } + } + } + + // Foreign keys must be created *after* unique keys for numerous DBs. See HH-8390. + iter = getTableMappings(); + while ( iter.hasNext() ) { + Table table = (Table) iter.next(); + if ( table.isPhysicalTable() ) { if ( dialect.hasAlterTable() ) { - subIter = table.getForeignKeyIterator(); + Iterator subIter = table.getForeignKeyIterator(); while ( subIter.hasNext() ) { ForeignKey fk = (ForeignKey) subIter.next(); if ( fk.isPhysicalConstraint() ) { @@ -1232,6 +1240,33 @@ public List generateSchemaUpdateScriptList(Dialect dialect, } } + Iterator subIter = table.getIndexIterator(); + while ( subIter.hasNext() ) { + final Index index = (Index) subIter.next(); + // Skip if index already exists + if ( tableInfo != null && StringHelper.isNotEmpty( index.getName() ) ) { + final IndexMetadata meta = tableInfo.getIndexMetadata( index.getName() ); + if ( meta != null ) { + continue; + } + } + scripts.add( new SchemaUpdateScript( index.sqlCreateString( dialect, mapping, tableCatalog, + tableSchema ), false ) ); + } + } + } + + // Foreign keys must be created *after* unique keys for numerous DBs. See HH-8390. + iter = getTableMappings(); + while ( iter.hasNext() ) { + Table table = (Table) iter.next(); + String tableSchema = ( table.getSchema() == null ) ? defaultSchema : table.getSchema(); + String tableCatalog = ( table.getCatalog() == null ) ? defaultCatalog : table.getCatalog(); + if ( table.isPhysicalTable() ) { + + TableMetadata tableInfo = databaseMetadata.getTableMetadata( table.getName(), tableSchema, + tableCatalog, table.isQuoted() ); + if ( dialect.hasAlterTable() ) { Iterator subIter = table.getForeignKeyIterator(); while ( subIter.hasNext() ) { @@ -1247,20 +1282,6 @@ public List generateSchemaUpdateScriptList(Dialect dialect, } } } - - Iterator subIter = table.getIndexIterator(); - while ( subIter.hasNext() ) { - final Index index = (Index) subIter.next(); - // Skip if index already exists - if ( tableInfo != null && StringHelper.isNotEmpty( index.getName() ) ) { - final IndexMetadata meta = tableInfo.getIndexMetadata( index.getName() ); - if ( meta != null ) { - continue; - } - } - scripts.add( new SchemaUpdateScript( index.sqlCreateString( dialect, mapping, tableCatalog, - tableSchema ), false ) ); - } } }