From e8fb4d84039614e209fbd3c62a7da86d65c91c03 Mon Sep 17 00:00:00 2001
From: Andrea Boriero <andrea@hibernate.org>
Date: Mon, 8 Feb 2021 16:26:09 +0100
Subject: [PATCH] HHH-14445 Javassist skip EntityWithMutableAttributesTest,
 LoadAndUpdateEntitiesWithCollectionsTest, SimpleDynamicUpdateTest,
 SimpleDynamicUpdateTest

---
 .../EntityWithMutableAttributesTest.java      | 12 ++++++++++
 ...dAndUpdateEntitiesWithCollectionsTest.java | 20 +++++++++++++++-
 .../SimpleDynamicUpdateTest.java              |  6 +++++
 .../DynamicUpdateAndCollectionsTest.java      | 23 ++++++++++++++++++-
 4 files changed, 59 insertions(+), 2 deletions(-)

diff --git a/hibernate-core/src/test/java/org/hibernate/test/bytecode/enhancement/lazy/proxy/inlinedirtychecking/EntityWithMutableAttributesTest.java b/hibernate-core/src/test/java/org/hibernate/test/bytecode/enhancement/lazy/proxy/inlinedirtychecking/EntityWithMutableAttributesTest.java
index 138d9cd3796d..4eed240516a0 100644
--- a/hibernate-core/src/test/java/org/hibernate/test/bytecode/enhancement/lazy/proxy/inlinedirtychecking/EntityWithMutableAttributesTest.java
+++ b/hibernate-core/src/test/java/org/hibernate/test/bytecode/enhancement/lazy/proxy/inlinedirtychecking/EntityWithMutableAttributesTest.java
@@ -64,6 +64,9 @@ protected void applyMetadataSources(MetadataSources sources) {
 
 	@Before
 	public void setUp() {
+		if ( skipTest ) {
+			return;
+		}
 		inTransaction(
 				session -> {
 					User user = new User();
@@ -87,6 +90,9 @@ public void setUp() {
 
 	@After
 	public void tearDown() {
+		if ( skipTest ) {
+			return;
+		}
 		inTransaction(
 				session -> {
 					session.createQuery( "delete from User" ).executeUpdate();
@@ -97,6 +103,9 @@ public void tearDown() {
 
 	@Test
 	public void testLoad() {
+		if ( skipTest ) {
+			return;
+		}
 		inTransaction(
 				session -> {
 					User user = session.load( User.class, 1 );
@@ -114,6 +123,9 @@ user, instanceOf( PersistentAttributeInterceptable.class )
 
 	@Test
 	public void testMutableAttributeIsUpdated() {
+		if ( skipTest ) {
+			return;
+		}
 		inTransaction(
 				session -> {
 					User user = session.load( User.class, 1 );
diff --git a/hibernate-core/src/test/java/org/hibernate/test/bytecode/enhancement/lazy/proxy/inlinedirtychecking/LoadAndUpdateEntitiesWithCollectionsTest.java b/hibernate-core/src/test/java/org/hibernate/test/bytecode/enhancement/lazy/proxy/inlinedirtychecking/LoadAndUpdateEntitiesWithCollectionsTest.java
index 2d28ef1c2974..668da7bb9775 100644
--- a/hibernate-core/src/test/java/org/hibernate/test/bytecode/enhancement/lazy/proxy/inlinedirtychecking/LoadAndUpdateEntitiesWithCollectionsTest.java
+++ b/hibernate-core/src/test/java/org/hibernate/test/bytecode/enhancement/lazy/proxy/inlinedirtychecking/LoadAndUpdateEntitiesWithCollectionsTest.java
@@ -63,6 +63,9 @@ protected void applyMetadataSources(MetadataSources sources) {
 
 	@Before
 	public void setUp() {
+		if ( skipTest ) {
+			return;
+		}
 		inTransaction(
 				session -> {
 					User user = new User();
@@ -90,7 +93,10 @@ public void setUp() {
 	}
 
 	@After
-	public void tearDwon() {
+	public void tearDown() {
+		if ( skipTest ) {
+			return;
+		}
 		inTransaction(
 				session -> {
 					session.createQuery( "delete from SamplingOrder" ).executeUpdate();
@@ -103,6 +109,9 @@ public void tearDwon() {
 
 	@Test
 	public void testLoad() {
+		if ( skipTest ) {
+			return;
+		}
 		inTransaction(
 				session -> {
 					CriteriaBuilder cb = session.getCriteriaBuilder();
@@ -126,6 +135,9 @@ public void testLoad() {
 
 	@Test
 	public void testAddUserRoles() {
+		if ( skipTest ) {
+			return;
+		}
 		inTransaction(
 				session -> {
 					SamplingOrder samplingOrder = getSamplingOrder( session );
@@ -200,6 +212,9 @@ public void testAddUserRoles() {
 
 	@Test
 	public void testDeleteUserRoles() {
+		if ( skipTest ) {
+			return;
+		}
 		inTransaction(
 				session -> {
 					SamplingOrder samplingOrder = getSamplingOrder( session );
@@ -220,6 +235,9 @@ public void testDeleteUserRoles() {
 
 	@Test
 	public void testModifyUserMail() {
+		if ( skipTest ) {
+			return;
+		}
 		inTransaction(
 				session -> {
 					SamplingOrder samplingOrder = getSamplingOrder( session );
diff --git a/hibernate-core/src/test/java/org/hibernate/test/bytecode/enhancement/lazy/proxy/inlinedirtychecking/SimpleDynamicUpdateTest.java b/hibernate-core/src/test/java/org/hibernate/test/bytecode/enhancement/lazy/proxy/inlinedirtychecking/SimpleDynamicUpdateTest.java
index bdf0eab5fa0a..491eae665f2c 100644
--- a/hibernate-core/src/test/java/org/hibernate/test/bytecode/enhancement/lazy/proxy/inlinedirtychecking/SimpleDynamicUpdateTest.java
+++ b/hibernate-core/src/test/java/org/hibernate/test/bytecode/enhancement/lazy/proxy/inlinedirtychecking/SimpleDynamicUpdateTest.java
@@ -63,6 +63,9 @@ protected void applyMetadataSources(MetadataSources sources) {
 
 	@Before
 	public void setUp() {
+		if ( skipTest ) {
+			return;
+		}
 		inTransaction(
 				session -> {
 					User user = new User();
@@ -88,6 +91,9 @@ public void setUp() {
 
 	@Test
 	public void testIt() {
+		if ( skipTest ) {
+			return;
+		}
 		inTransaction(
 				session -> {
 					User user = session.getReference( User.class, 1 );
diff --git a/hibernate-core/src/test/java/org/hibernate/test/bytecode/enhancement/lazy/proxy/inlinedirtychecking/dynamicupdate/DynamicUpdateAndCollectionsTest.java b/hibernate-core/src/test/java/org/hibernate/test/bytecode/enhancement/lazy/proxy/inlinedirtychecking/dynamicupdate/DynamicUpdateAndCollectionsTest.java
index 24616b88340d..a258efd8d8a9 100644
--- a/hibernate-core/src/test/java/org/hibernate/test/bytecode/enhancement/lazy/proxy/inlinedirtychecking/dynamicupdate/DynamicUpdateAndCollectionsTest.java
+++ b/hibernate-core/src/test/java/org/hibernate/test/bytecode/enhancement/lazy/proxy/inlinedirtychecking/dynamicupdate/DynamicUpdateAndCollectionsTest.java
@@ -66,6 +66,9 @@ protected void applyMetadataSources(MetadataSources sources) {
 
 	@Before
 	public void setUp() {
+		if ( skipTest ) {
+			return;
+		}
 		inTransaction(
 				session -> {
 					User user = new User();
@@ -92,7 +95,10 @@ public void setUp() {
 	}
 
 	@After
-	public void tearDwon() {
+	public void tearDown() {
+		if ( skipTest ) {
+			return;
+		}
 		inTransaction(
 				session -> {
 					session.createQuery( "delete from SamplingOrder" ).executeUpdate();
@@ -105,6 +111,9 @@ public void tearDwon() {
 
 	@Test
 	public void testLoad() {
+		if ( skipTest ) {
+			return;
+		}
 		inTransaction(
 				session -> {
 					CriteriaBuilder cb = session.getCriteriaBuilder();
@@ -128,6 +137,9 @@ public void testLoad() {
 
 	@Test
 	public void testRemoveCustomers() {
+		if ( skipTest ) {
+			return;
+		}
 		Long samplingOrderId = fromTransaction(
 				session -> {
 					SamplingOrder samplingOrder = getSamplingOrderFetchCustomer( session );
@@ -146,6 +158,9 @@ public void testRemoveCustomers() {
 
 	@Test
 	public void testAddUserRoles() {
+		if ( skipTest ) {
+			return;
+		}
 		inTransaction(
 				session -> {
 					SamplingOrder samplingOrder = getSamplingOrderFetchCustomer( session );
@@ -207,6 +222,9 @@ public void testAddUserRoles() {
 
 	@Test
 	public void testDeleteUserRoles() {
+		if ( skipTest ) {
+			return;
+		}
 		inTransaction(
 				session -> {
 					SamplingOrder samplingOrder = getSamplingOrderFetchCustomer( session );
@@ -226,6 +244,9 @@ public void testDeleteUserRoles() {
 
 	@Test
 	public void testModifyUserMail() {
+		if ( skipTest ) {
+			return;
+		}
 		inTransaction(
 				session -> {
 					SamplingOrder samplingOrder = getSamplingOrderFetchCustomer( session );