Log failing SQL when batched execution fails with RTE like StaleStateException #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the Pull Request. Please create a JIRA issue and make sure that you sign the CLA as well. |
Log failing SQL when batched execution fails with RuntimeException like StaleStateException.
findepi
force-pushed
the
log-failing-sql-when-batch-StaleStateException
branch
from
0581423
to
5710f82
Compare
|
@vladmihalcea I've created https://hibernate.atlassian.net/browse/HHH-11082 and updated commit message accordingly. Yes, I've signed CLA. |
|
Thanks |
|
@vladmihalcea this is now ready for review. |
|
Thanks for the PR. I applied it upstream. |
|
Thanks! |
dantewang
added a commit
to dantewang/liferay-portal
that referenced
this pull request
Jul 1, 2021
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
This was referenced Jul 1, 2021
dantewang
added a commit
to dantewang/liferay-portal
that referenced
this pull request
Jul 2, 2021
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
yuhai
pushed a commit
to yuhai/liferay-portal
that referenced
this pull request
Jul 5, 2021
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
dantewang
added a commit
to dantewang/liferay-portal
that referenced
this pull request
Jul 6, 2021
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
yuhai
pushed a commit
to yuhai/liferay-portal
that referenced
this pull request
Jul 6, 2021
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
dantewang
added a commit
to dantewang/liferay-portal
that referenced
this pull request
Jul 7, 2021
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
dantewang
added a commit
to dantewang/liferay-portal
that referenced
this pull request
Jul 16, 2021
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
dantewang
added a commit
to dantewang/liferay-portal
that referenced
this pull request
Jul 19, 2021
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
dantewang
added a commit
to dantewang/liferay-portal
that referenced
this pull request
Jul 29, 2021
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
dantewang
added a commit
to dantewang/liferay-portal
that referenced
this pull request
Aug 19, 2021
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
yuhai
pushed a commit
to yuhai/liferay-portal
that referenced
this pull request
Sep 13, 2021
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
yuhai
pushed a commit
to yuhai/liferay-portal
that referenced
this pull request
Dec 15, 2021
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
yuhai
pushed a commit
to yuhai/liferay-portal
that referenced
this pull request
Dec 16, 2021
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
yuhai
pushed a commit
to yuhai/liferay-portal
that referenced
this pull request
Dec 21, 2021
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
yuhai
pushed a commit
to yuhai/liferay-portal
that referenced
this pull request
Dec 22, 2021
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
yuhai
pushed a commit
to yuhai/liferay-portal
that referenced
this pull request
Jan 17, 2022
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
yuhai
pushed a commit
to yuhai/liferay-portal
that referenced
this pull request
Jan 19, 2022
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
yuhai
pushed a commit
to yuhai/liferay-portal
that referenced
this pull request
Jan 21, 2022
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
yuhai
pushed a commit
to yuhai/liferay-portal
that referenced
this pull request
Jan 28, 2022
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
yuhai
pushed a commit
to yuhai/liferay-portal
that referenced
this pull request
Feb 8, 2022
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
yuhai
pushed a commit
to yuhai/liferay-portal
that referenced
this pull request
Feb 15, 2022
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
dantewang
added a commit
to dantewang/liferay-portal
that referenced
this pull request
Feb 21, 2022
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
dantewang
added a commit
to dantewang/liferay-portal
that referenced
this pull request
Feb 22, 2022
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
dantewang
added a commit
to dantewang/liferay-portal
that referenced
this pull request
Feb 22, 2022
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
dantewang
added a commit
to dantewang/liferay-portal
that referenced
this pull request
Feb 23, 2022
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
dantewang
added a commit
to dantewang/liferay-portal
that referenced
this pull request
Feb 23, 2022
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
dantewang
added a commit
to dantewang/liferay-portal
that referenced
this pull request
Mar 1, 2022
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
dantewang
added a commit
to dantewang/liferay-portal
that referenced
this pull request
Mar 2, 2022
…se SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
dantewang
added a commit
to dantewang/liferay-portal
that referenced
this pull request
Mar 7, 2022
…because SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
dantewang
added a commit
to dantewang/liferay-portal
that referenced
this pull request
Mar 8, 2022
…because SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
dantewang
added a commit
to dantewang/liferay-portal
that referenced
this pull request
Mar 10, 2022
…because SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
yuhai
pushed a commit
to yuhai/liferay-portal
that referenced
this pull request
Mar 16, 2022
…because SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
dantewang
added a commit
to dantewang/liferay-portal
that referenced
this pull request
Mar 17, 2022
…because SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
dantewang
added a commit
to dantewang/liferay-portal
that referenced
this pull request
Mar 18, 2022
…because SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
dantewang
added a commit
to dantewang/liferay-portal
that referenced
this pull request
Mar 23, 2022
…because SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
dantewang
added a commit
to dantewang/liferay-portal
that referenced
this pull request
Mar 31, 2022
…because SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544
dantewang
added a commit
to dantewang/liferay-portal
that referenced
this pull request
Apr 7, 2022
…ing in BatchingBatch. SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544.
shuyangzhou
pushed a commit
to shuyangzhou/liferay-portal
that referenced
this pull request
Apr 8, 2022
…ing in BatchingBatch. SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544.
brianchandotcom
pushed a commit
to brianchandotcom/liferay-portal
that referenced
this pull request
Apr 9, 2022
…ing in BatchingBatch. SQLExceptions in BatchingBatch are logged twice -- see hibernate/hibernate-orm#1544.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when using batched updates and Hibernate detects stale state (e.g. data row concurrently deleted or deleted by JPQL executed with NO_FLUSH), failing SQL is not logged. However, when SQLException occurs, the failing SQL is logged (and that's so much convenient!).
This patch changes how we handle non-SQLException exception when executing batch, so that current SQL is logged for them as well.