New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkstyle licence header #2085

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@dreab8
Member

dreab8 commented Dec 14, 2017

I have added the shared/config/checkstyle/license.header file that contains the regex used inside shared/config/checkstyle/checkstyle.xml to match both version of the header
/*

  • Hibernate, Relational Persistence for Idiomatic Java
  • License: GNU Lesser General Public License (LGPL), version 2.1 or later.
  • See the lgpl.txt file in the root directory or http://www.gnu.org/licenses/lgpl-2.1.html.
    /
    or
    /
  • Hibernate, Relational Persistence for Idiomatic Java
  • License: GNU Lesser General Public License (LGPL), version 2.1 or later
  • See the lgpl.txt file in the root directory or http://www.gnu.org/licenses/lgpl-2.1.html
    */

The other changes add a new line at the end of some files that did't have it causing a checkstyle error.

@dreab8 dreab8 requested a review from sebersole Dec 14, 2017

@dreab8

This comment has been minimized.

Show comment
Hide comment
@dreab8

dreab8 Dec 15, 2017

Member

The only think I do not like is that with this change the error messages contain the regexp.
By example if the header does not match "* License: GNU Lesser General Public License (LGPL), version 2.1 or later." the error message will be
"Line does not match expected header line of '^ * License: GNU Lesser General Public License (LGPL), version 2.1 or later(.)?$'"
but not sure if this is a real problem.

Member

dreab8 commented Dec 15, 2017

The only think I do not like is that with this change the error messages contain the regexp.
By example if the header does not match "* License: GNU Lesser General Public License (LGPL), version 2.1 or later." the error message will be
"Line does not match expected header line of '^ * License: GNU Lesser General Public License (LGPL), version 2.1 or later(.)?$'"
but not sure if this is a real problem.

@sebersole

This comment has been minimized.

Show comment
Hide comment
@sebersole

sebersole Dec 15, 2017

Member

I think the error message is fine. It is clear that the issue is the license header, which is the important part.

Member

sebersole commented Dec 15, 2017

I think the error message is fine. It is clear that the issue is the license header, which is the important part.

@sebersole

This comment has been minimized.

Show comment
Hide comment
@sebersole

sebersole Dec 17, 2017

Member

@Naros You said you had a follow up to this?

Member

sebersole commented Dec 17, 2017

@Naros You said you had a follow up to this?

@Naros

This comment has been minimized.

Show comment
Hide comment
@Naros

Naros Jan 11, 2018

Member

I have already integrated a solution on master and missed this PR. Closing.

Member

Naros commented Jan 11, 2018

I have already integrated a solution on master and missed this PR. Closing.

@Naros Naros closed this Jan 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment