Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

"--" comment bug fix #359

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants

Fixed bug that can cause a SQL Query to become invalid after being formatted. This occurs when a "--" comment is used within the query.

Obviously, ignore the "test..." commit... I couldn't figure out how to remove that commit from the pull request.

Member

stliu commented Aug 6, 2012

would you provider a test case and create a JIRA ? thanks

Member

brmeyer commented Sep 19, 2012

@shilobar Can you create a JIRA ticket at https://hibernate.onjira.com? Can you also 1.) add a test case to this pull request (preferred) or 2.) attach the test to the JIRA ticket?

@brmeyer brmeyer commented on the diff Oct 24, 2012

changelog.txt
@@ -5,6 +5,9 @@ match the actual issue resolution (i.e. a bug might not be a bug). Please
refer to the particular case on JIRA using the issue tracking number to learn
more about each case.
+
@brmeyer

brmeyer Oct 24, 2012

Member

Please remove this file from your commit.

@shilobar

shilobar Nov 13, 2012

I think you mean remove the "test" commit (for changelog.txt) from my pull request? Is there a way I can do that in the web interface?

@stliu

stliu Nov 13, 2012

Member

dont think so, easier to create a new one

On Nov 13, 2012, at 11:43 AM, shilobar notifications@github.com wrote:

In changelog.txt:

@@ -5,6 +5,9 @@ match the actual issue resolution (i.e. a bug might not be a bug). Please
refer to the particular case on JIRA using the issue tracking number to learn
more about each case.

I think you mean remove the "test" commit (for changelog.txt) rom my pull request? Is there a way I can do that in the web interface?


Reply to this email directly or view it on GitHub.


Best Regards,

Strong Liu
http://about.me/stliu/bio

@shilobar shilobar closed this Nov 13, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment