Updated CUBRID Database Dialect. #361

Closed
wants to merge 43 commits into
from

Conversation

Projects
None yet
7 participants
Contributor

kadishmal commented Jul 24, 2012

Updated CUBRID Dialect.

  • Added supported SQL functions and data types.
  • Removed limit related methods in favor of CUBRIDLimitHandler.
  • Improved the dialect by correctly setting values (true/false) for certain dialect features.
  • Registered reserved words for CUBRID dialect.
  • Renamed smallint data type to short. Sinonyms in CUBRID but internally stored as short.
  • Fixed a bug which prevented boolean types to be stored to a database. Correct data type should be bit(8).

kadishmal added some commits Jul 18, 2012

Updated CUBRIDDialect.
Added supported SQL functions and data types. Removed limit related
methods in favor of CUBRIDLimitHandler. Improved the dialect by
correctly setting values (true/false) for certain dialect features.
Skip this JoinedSubClassTest for CUBRID dialect as temp tables are no…
…t supported yet.

Raises "HibernateException: cannot doAfterTransactionCompletion
multi-table deletes using dialect not supporting temp tables".
Skip these tests for CUBRID dialect as temp tables aren't supported yet.
Raises: "HibernateException: cannot doAfterTransactionCompletion
multi-table deletes using dialect not supporting temp tables"

@ghost ghost assigned stliu Sep 5, 2012

Ivan Sopov and others added some commits Sep 14, 2012

fix for HHH-7487 org.hibernate.type.EnumType incorrectly logs binded …
…values, trace logging was done as it is done in BasicBinder with the String.format
HHH-7603 Changed AbstractPersistentCollection so that it would behave…
… in a similar manner as 4.1.6 when using the default lazy load behavior for collections. With the changes for HHH-7603 the AbstractPersistentCollection was throwing a NPE instead of a LIE in a very particular case.

Added test that simulates a use case from Hibernate Search 4.1.1 as far as I can tell.
HHH-7620 - allow ValidatorFactory to be passed into EntityManagerFact…
…oryBuilder : reordered EMF builder processing to better allow late ValidatorFactory and DataSource (HHH-7621) passing
HHH-5209 - org.hibernate.hql.ast.QuerySyntaxException when running a …
…JPQL query with a MEMBER OF on an @ElementCollection
HHH-7674 DB locks not cleared on
LazyLoadingTest#testLazyCollectionLoadingWithClearedSession
Updated CUBRIDDialect.
Added supported SQL functions and data types. Removed limit related
methods in favor of CUBRIDLimitHandler. Improved the dialect by
correctly setting values (true/false) for certain dialect features.
Skip this JoinedSubClassTest for CUBRID dialect as temp tables are no…
…t supported yet.

Raises "HibernateException: cannot doAfterTransactionCompletion
multi-table deletes using dialect not supporting temp tables".
Skip these tests for CUBRID dialect as temp tables aren't supported yet.
Raises: "HibernateException: cannot doAfterTransactionCompletion
multi-table deletes using dialect not supporting temp tables"
Added a fallback data type for cases when VARCHAR length is over 4000…
… chars.

In such cases the column type will be STRING which is equivalent to
VARCHAR(1,073,741,823).
Member

brmeyer commented Oct 25, 2012

@kadishmal, thank you for the contribution.

However, in the future, may I ask a couple of favors? Please avoid the use of 'merge'. Always use 'rebase' to avoid adding all of these irrelevant commits to your PR. It's a lot harder for us to pull in the PR in this state. Also, always open a JIRA ticket and reference the ticket # in your commit messages.

That being said, I was able to do this one manually since the changes were all very isolated and cherry-pickable. Commit messages were changed to include HHH-7716.

Thanks!

@brmeyer brmeyer closed this Oct 25, 2012

Contributor

kadishmal commented Oct 26, 2012

  1. rebase - got it.
  2. I used to open JIRA issue before, then last time I received a message that I can directly send a pull request which would be enough. So, stopped creating JIRA issues. I will from now on.

Thank you for your attention to my PR.

@kadishmal kadishmal deleted the CUBRID:upstream_master branch Feb 21, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment