New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Envers bugfix hhh 7682 #393

Merged
merged 3 commits into from Oct 11, 2012

Conversation

Projects
None yet
2 participants
@tdziurko

tdziurko commented Oct 11, 2012

Issue is described on JIRA: https://hibernate.onjira.com/browse/HHH-7682.

Fix contains small modification how AuditProcessManager behaves when EntityManager is reused to start next transaction after previous one was rolled back.

@adamw

This comment has been minimized.

Show comment
Hide comment
@adamw

adamw Oct 11, 2012

Member

Shouldn't this be a separate test, not one of the "basic" tests?

Member

adamw commented Oct 11, 2012

Shouldn't this be a separate test, not one of the "basic" tests?

@tdziurko

This comment has been minimized.

Show comment
Hide comment
@tdziurko

tdziurko Oct 11, 2012

I was thinking that is is one of the basic functionalities similar to saving audit records when inserting data to the database as tests consistenty of rollback behaviour.

tdziurko commented Oct 11, 2012

I was thinking that is is one of the basic functionalities similar to saving audit records when inserting data to the database as tests consistenty of rollback behaviour.

@adamw

This comment has been minimized.

Show comment
Hide comment
@adamw

adamw Oct 11, 2012

Member

Well this is more of a specific case, where you have two txs for one session. I'd put it in a separate test ;)

Member

adamw commented Oct 11, 2012

Well this is more of a specific case, where you have two txs for one session. I'd put it in a separate test ;)

@tdziurko

This comment has been minimized.

Show comment
Hide comment
@tdziurko

tdziurko Oct 11, 2012

Ok, as suggested, tests is now in a separate class.

tdziurko commented Oct 11, 2012

Ok, as suggested, tests is now in a separate class.

adamw added a commit that referenced this pull request Oct 11, 2012

@adamw adamw merged commit 1555ba9 into hibernate:3.6 Oct 11, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment