From 9ebb5a89b1d991fc189c9f28c1e0ae6bebaff82f Mon Sep 17 00:00:00 2001
From: "nathan.xu" <nathan.xu@procor.com>
Date: Sat, 9 Nov 2024 12:00:22 -0500
Subject: [PATCH 1/5] improve some Javadocs in sql package

---
 .../src/main/java/org/hibernate/sql/Delete.java           | 2 +-
 .../main/java/org/hibernate/sql/ForUpdateFragment.java    | 2 +-
 .../src/main/java/org/hibernate/sql/InFragment.java       | 2 +-
 .../src/main/java/org/hibernate/sql/Insert.java           | 2 +-
 .../main/java/org/hibernate/sql/NullnessRestriction.java  | 2 +-
 .../src/main/java/org/hibernate/sql/SimpleSelect.java     | 2 +-
 .../src/main/java/org/hibernate/sql/Template.java         | 4 ++--
 .../src/main/java/org/hibernate/sql/Update.java           | 2 +-
 .../src/main/java/org/hibernate/sql/ast/Clause.java       | 8 ++------
 .../main/java/org/hibernate/sql/ast/SqlAstJoinType.java   | 2 +-
 .../main/java/org/hibernate/sql/ast/SqlAstTranslator.java | 4 ++--
 .../src/main/java/org/hibernate/sql/ast/package-info.java | 2 +-
 .../hibernate/sql/ast/spi/AbstractSqlAstTranslator.java   | 2 +-
 .../org/hibernate/sql/ast/spi/SqlAliasBaseManager.java    | 2 +-
 .../org/hibernate/sql/ast/spi/SqlAstCreationContext.java  | 2 +-
 .../org/hibernate/sql/ast/spi/SqlAstCreationState.java    | 2 +-
 .../org/hibernate/sql/ast/spi/SqlAstProcessingState.java  | 2 +-
 .../main/java/org/hibernate/sql/ast/spi/package-info.java | 2 +-
 .../java/org/hibernate/sql/exec/spi/JdbcLockStrategy.java | 2 +-
 .../sql/exec/spi/JdbcOperationQueryAnonBlock.java         | 2 +-
 .../results/internal/NavigablePathMapToInitializer.java   | 8 +++++---
 .../hibernate/sql/results/spi/ListResultsConsumer.java    | 4 ++--
 .../java/org/hibernate/sql/results/spi/RowReader.java     | 4 ++--
 23 files changed, 32 insertions(+), 34 deletions(-)

diff --git a/hibernate-core/src/main/java/org/hibernate/sql/Delete.java b/hibernate-core/src/main/java/org/hibernate/sql/Delete.java
index bc00167d7021..8273f9e5f389 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/Delete.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/Delete.java
@@ -13,7 +13,7 @@
 import org.hibernate.sql.ast.spi.ParameterMarkerStrategy;
 
 /**
- * A SQL {@code DELETE} statement.
+ * An SQL {@code DELETE} statement.
  *
  * @author Gavin King
  */
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/ForUpdateFragment.java b/hibernate-core/src/main/java/org/hibernate/sql/ForUpdateFragment.java
index 6f034a20d8f9..d14c0053fc81 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/ForUpdateFragment.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/ForUpdateFragment.java
@@ -14,7 +14,7 @@
 import org.hibernate.internal.util.StringHelper;
 
 /**
- * A SQL {FOR UPDATE} clause.
+ * An SQL {@code FOR UPDATE} clause.
  *
  * @author Gavin King
  */
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/InFragment.java b/hibernate-core/src/main/java/org/hibernate/sql/InFragment.java
index 5a17b2ab83c7..69a18b663d51 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/InFragment.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/InFragment.java
@@ -12,7 +12,7 @@
 import org.hibernate.internal.util.StringHelper;
 
 /**
- * A SQL {@code IN} expression.
+ * An SQL {@code IN} expression.
  *
  * @author Gavin King
  */
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/Insert.java b/hibernate-core/src/main/java/org/hibernate/sql/Insert.java
index e4dbd7d7bd7a..70ca912aa055 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/Insert.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/Insert.java
@@ -18,7 +18,7 @@
 
 
 /**
- * A SQL {@code INSERT} statement.
+ * An SQL {@code INSERT} statement.
  *
  * @author Gavin King
  */
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/NullnessRestriction.java b/hibernate-core/src/main/java/org/hibernate/sql/NullnessRestriction.java
index b8a1dc581924..fd77e22e6266 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/NullnessRestriction.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/NullnessRestriction.java
@@ -7,7 +7,7 @@
 import org.hibernate.Internal;
 
 /**
- * Nullness restriction - IS (NOT)? NULL
+ * Nullness restriction - IS (NOT) NULL ?
  *
  * @author Steve Ebersole
  */
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/SimpleSelect.java b/hibernate-core/src/main/java/org/hibernate/sql/SimpleSelect.java
index 4b12127d5c08..e5323621928e 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/SimpleSelect.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/SimpleSelect.java
@@ -20,7 +20,7 @@
 import org.hibernate.sql.ast.spi.ParameterMarkerStrategy;
 
 /**
- * A SQL {@code SELECT} statement with no table joins.
+ * An SQL {@code SELECT} statement with no table joins.
  *
  * @author Gavin King
  */
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/Template.java b/hibernate-core/src/main/java/org/hibernate/sql/Template.java
index 2be9d04f1cb5..23d9e4a8ed1c 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/Template.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/Template.java
@@ -23,12 +23,12 @@
  * should be written in the native SQL dialect of the target database,
  * with the following special exceptions:
  * <ul>
- *     <li>any backtick-quoted identifiers, for example {@code `hello`},
+ *     <li>any backtick-quoted identifier, for example {@code `hello`},
  *     is interpreted as a quoted identifier and re-quoted using the
  *     {@linkplain Dialect#quote native quoted identifier syntax} of
  *     the database, and</li>
  *     <li>the literal identifiers {@code true} and {@code false} are
- *     interpreted are literal boolean values, and replaced with
+ *     interpreted as literal boolean values, and replaced with
  *     {@linkplain Dialect#toBooleanValueString dialect-specific
  *     literal values}.
  *     </li>
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/Update.java b/hibernate-core/src/main/java/org/hibernate/sql/Update.java
index 38fe7e62c6d3..66bce7f70e83 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/Update.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/Update.java
@@ -15,7 +15,7 @@
 import org.hibernate.sql.ast.spi.ParameterMarkerStrategy;
 
 /**
- * A SQL {@code UPDATE} statement.
+ * An SQL {@code UPDATE} statement.
  *
  * @author Gavin King
  */
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/ast/Clause.java b/hibernate-core/src/main/java/org/hibernate/sql/ast/Clause.java
index ccfda72b1ad6..127375063b0c 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/ast/Clause.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/ast/Clause.java
@@ -39,9 +39,8 @@ public enum Clause {
 	SET_EXPRESSION,
 
 	/**
-	 * Not used in 5.x.  Intended for use in 6+ as indicator
-	 * of processing predicates (where clause) that occur in a
-	 * delete
+	 * Used as indicator of processing predicates (where clause)
+	 * that occur in a delete
 	 */
 	DELETE,
 	MERGE,
@@ -64,9 +63,6 @@ public enum Clause {
 	CONFLICT,
 	CALL,
 
-	/**
-	 * Again, not used in 5.x.  Used in 6+
-	 */
 	IRRELEVANT
 
 }
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/ast/SqlAstJoinType.java b/hibernate-core/src/main/java/org/hibernate/sql/ast/SqlAstJoinType.java
index c7e88c366325..a530443dedd0 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/ast/SqlAstJoinType.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/ast/SqlAstJoinType.java
@@ -24,7 +24,7 @@ public enum SqlAstJoinType {
 	RIGHT( "right " ),
 
 	/**
-	 * Represents a cross join (aka a cartesian product).
+	 * Represents a cross join (aka a Cartesian product).
 	 */
 	CROSS( "cross " ),
 
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/ast/SqlAstTranslator.java b/hibernate-core/src/main/java/org/hibernate/sql/ast/SqlAstTranslator.java
index 72997846cbbe..5f3ba57f3db8 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/ast/SqlAstTranslator.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/ast/SqlAstTranslator.java
@@ -57,8 +57,8 @@ public interface SqlAstTranslator<T extends JdbcOperation> extends SqlAstWalker
 	Stack<Clause> getCurrentClauseStack();
 
 	/**
-	 * Not the best spot for this.  Its the table names collected while walking the SQL AST.
-	 * Its ok here because the translator is consider a one-time-use.  It just needs to be called
+	 * Not the best spot for this.  Returns the table names collected while walking the SQL AST.
+	 * It's ok here because the translator is consider a one-time-use.  It just needs to be called
 	 * after translation.
 	 *
 	 * A better option is probably to have "translation" objects that expose the affected table-names.
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/ast/package-info.java b/hibernate-core/src/main/java/org/hibernate/sql/ast/package-info.java
index 8bc84339372a..c95d664490c4 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/ast/package-info.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/ast/package-info.java
@@ -6,7 +6,7 @@
  */
 
 /**
- * Package defining a SQL AST for use in generation of SQL.
+ * Package defining an SQL AST for use in generation of SQL.
  * <p>
  * The SQL AST is an intermediate product of the {@linkplain org.hibernate.query.hql process}
  * of translating a HQL or criteria query to SQL.
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java b/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java
index 85d5710bae91..d8b7baaf2d46 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java
@@ -246,7 +246,7 @@ public abstract class AbstractSqlAstTranslator<T extends JdbcOperation> implemen
 
 	/**
 	 * When emulating the recursive WITH clause subclauses SEARCH and CYCLE,
-	 * we need to build a string path and some database like MySQL require that
+	 * we need to build a string path and some database like MySQL requires that
 	 * we cast the expression to a char with certain size.
 	 * To estimate the size, we need to assume a certain max recursion depth.
 	 */
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAliasBaseManager.java b/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAliasBaseManager.java
index f419132db5a0..ce3ec831b35e 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAliasBaseManager.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAliasBaseManager.java
@@ -9,7 +9,7 @@
 import java.util.Set;
 
 /**
- * Helper used in creating unique SQL table aliases for a SQL AST
+ * Helper used in creating unique SQL table aliases for an SQL AST
  *
  * @author Steve Ebersole
  */
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAstCreationContext.java b/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAstCreationContext.java
index 6f4250c86892..19401dde2c70 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAstCreationContext.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAstCreationContext.java
@@ -10,7 +10,7 @@
 
 /**
  * The "context" in which creation of SQL AST occurs.  Provides
- * access to generally needed when creating SQL AST nodes
+ * access to stuff generally needed when creating SQL AST nodes
  *
  * @author Steve Ebersole
  */
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAstCreationState.java b/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAstCreationState.java
index 7c32e8d192d5..9eb8163993e0 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAstCreationState.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAstCreationState.java
@@ -12,7 +12,7 @@
 import org.hibernate.sql.ast.tree.from.TableGroup;
 
 /**
- * Access to stuff used while creating a SQL AST
+ * Access to stuff used while creating an SQL AST
  *
  * @author Steve Ebersole
  */
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAstProcessingState.java b/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAstProcessingState.java
index 8444146842c0..f6501f9ebd29 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAstProcessingState.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAstProcessingState.java
@@ -6,7 +6,7 @@
 
 /**
  * Generalized access to state information relative to the "current process" of
- * creating a SQL AST.
+ * creating an SQL AST.
  *
  * @author Steve Ebersole
  */
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/package-info.java b/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/package-info.java
index 772e93783fc9..18e96eee3649 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/package-info.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/package-info.java
@@ -6,6 +6,6 @@
  */
 
 /**
- * Package defining support for creating and consuming a SQL AST.
+ * Package defining support for creating and consuming an SQL AST.
  */
 package org.hibernate.sql.ast.spi;
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/exec/spi/JdbcLockStrategy.java b/hibernate-core/src/main/java/org/hibernate/sql/exec/spi/JdbcLockStrategy.java
index d5cb85ea73cc..3f866d89df36 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/exec/spi/JdbcLockStrategy.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/exec/spi/JdbcLockStrategy.java
@@ -12,7 +12,7 @@
 public enum JdbcLockStrategy {
 
 	/**
-	 * Use a dialect specific check to determine how to apply locks.
+	 * Use a dialect-specific check to determine how to apply locks.
 	 */
 	AUTO,
 	/**
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/exec/spi/JdbcOperationQueryAnonBlock.java b/hibernate-core/src/main/java/org/hibernate/sql/exec/spi/JdbcOperationQueryAnonBlock.java
index 8ad01e3d9a61..3025bd54cb92 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/exec/spi/JdbcOperationQueryAnonBlock.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/exec/spi/JdbcOperationQueryAnonBlock.java
@@ -8,7 +8,7 @@
 
 /**
  * An anonymous call block (sometimes called an anonymous procedure) to be executed
- * on the database.  The format of this various by database, but it is essentially an
+ * on the database.  The format of this varies by database, but it is essentially an
  * unnamed procedure without OUT, INOUT or REF_CURSOR type parameters
  *
  * @author Steve Ebersole
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/results/internal/NavigablePathMapToInitializer.java b/hibernate-core/src/main/java/org/hibernate/sql/results/internal/NavigablePathMapToInitializer.java
index d4dcb034412e..7e41093c2743 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/results/internal/NavigablePathMapToInitializer.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/results/internal/NavigablePathMapToInitializer.java
@@ -15,10 +15,12 @@
 
 /**
  * This is in all practical terms a {@code Map<NavigablePath, Initializer>}
- * but wrapping an HashMap so to keep the client code readable as we need
+ * but wrapping a {@code HashMap} to keep the client code readable as we need
  * to:
- * a) have a way to log all initializers
- * b) prevent type pollution from happening on Initializer retrieval
+ * <ul>
+ *     <li>have a way to log all initializers</li>
+ *     <li>prevent type pollution from happening on Initializer retrieval</li>
+ * </ul>
  * I also consider it good practice to only expose the minimal set of
  * operations the client actually needs.
  */
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/results/spi/ListResultsConsumer.java b/hibernate-core/src/main/java/org/hibernate/sql/results/spi/ListResultsConsumer.java
index baca843a066e..5a679e7f114a 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/results/spi/ListResultsConsumer.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/results/spi/ListResultsConsumer.java
@@ -33,8 +33,8 @@
 public class ListResultsConsumer<R> implements ResultsConsumer<List<R>, R> {
 
 	/**
-	 * Let's be reasonable, a row estimate greater than 1M rows is probably either a mis-estimation or bug,
-	 * so let's set 2^20 which is a bit above 1M as maximum collection size.
+	 * Let's be reasonable, a row estimated greater than 1M rows is probably either a mis-estimation or bug,
+	 * so let's set {@code 2^20} which is a bit above 1M as maximum collection size.
 	 */
 	private static final int INITIAL_COLLECTION_SIZE_LIMIT = 1 << 20;
 
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/results/spi/RowReader.java b/hibernate-core/src/main/java/org/hibernate/sql/results/spi/RowReader.java
index 2f61ea91d1f6..fbda3398dc0f 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/results/spi/RowReader.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/results/spi/RowReader.java
@@ -22,9 +22,9 @@ public interface RowReader<R> {
 	 * The type actually returned from this reader's {@link #readRow} call,
 	 * accounting for any transformers.
 	 * <p>
-	 * May be null to indicate that no transformation is applied.
+	 * May be {@code null} to indicate that no transformation is applied.
 	 * <p>
-	 * Ultimately intended for use in comparing values are being de-duplicated
+	 * Ultimately intended for use in comparing values that are being de-duplicated
 	 */
 	Class<R> getDomainResultResultJavaType();
 

From 0d8493b3e3574df5f78a5d026674d397865c051d Mon Sep 17 00:00:00 2001
From: Nathan Xu <nathan.qingyang.xu@gmail.com>
Date: Sun, 10 Nov 2024 21:38:07 -0500
Subject: [PATCH 2/5] Update
 hibernate-core/src/main/java/org/hibernate/sql/ast/SqlAstJoinType.java

Co-authored-by: Gavin King <gavin@hibernate.org>
---
 .../src/main/java/org/hibernate/sql/ast/SqlAstJoinType.java     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hibernate-core/src/main/java/org/hibernate/sql/ast/SqlAstJoinType.java b/hibernate-core/src/main/java/org/hibernate/sql/ast/SqlAstJoinType.java
index a530443dedd0..53b06335dcb7 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/ast/SqlAstJoinType.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/ast/SqlAstJoinType.java
@@ -24,7 +24,7 @@ public enum SqlAstJoinType {
 	RIGHT( "right " ),
 
 	/**
-	 * Represents a cross join (aka a Cartesian product).
+	 * Represents a cross join (that is, a Cartesian product).
 	 */
 	CROSS( "cross " ),
 

From 5a9fe68fdfe201d82c29bce10e8493b41e95155d Mon Sep 17 00:00:00 2001
From: Nathan Xu <nathan.qingyang.xu@gmail.com>
Date: Sun, 10 Nov 2024 21:38:20 -0500
Subject: [PATCH 3/5] Update
 hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java

Co-authored-by: Gavin King <gavin@hibernate.org>
---
 .../org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java b/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java
index d8b7baaf2d46..516ab521f286 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java
@@ -246,7 +246,7 @@ public abstract class AbstractSqlAstTranslator<T extends JdbcOperation> implemen
 
 	/**
 	 * When emulating the recursive WITH clause subclauses SEARCH and CYCLE,
-	 * we need to build a string path and some database like MySQL requires that
+	 * we need to build a string path and some databases like MySQL require that
 	 * we cast the expression to a char with certain size.
 	 * To estimate the size, we need to assume a certain max recursion depth.
 	 */

From 4f6041230f943a71c18964fc05e32ee967b25d0c Mon Sep 17 00:00:00 2001
From: Nathan Xu <nathan.qingyang.xu@gmail.com>
Date: Sun, 10 Nov 2024 21:38:39 -0500
Subject: [PATCH 4/5] Update
 hibernate-core/src/main/java/org/hibernate/sql/results/spi/ListResultsConsumer.java

Co-authored-by: Gavin King <gavin@hibernate.org>
---
 .../java/org/hibernate/sql/results/spi/ListResultsConsumer.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hibernate-core/src/main/java/org/hibernate/sql/results/spi/ListResultsConsumer.java b/hibernate-core/src/main/java/org/hibernate/sql/results/spi/ListResultsConsumer.java
index 5a679e7f114a..11c0f1fdc7be 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/results/spi/ListResultsConsumer.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/results/spi/ListResultsConsumer.java
@@ -33,7 +33,7 @@
 public class ListResultsConsumer<R> implements ResultsConsumer<List<R>, R> {
 
 	/**
-	 * Let's be reasonable, a row estimated greater than 1M rows is probably either a mis-estimation or bug,
+	 * Let's be reasonable: a row estimate greater than 1M rows is probably either a misestimate or a bug,
 	 * so let's set {@code 2^20} which is a bit above 1M as maximum collection size.
 	 */
 	private static final int INITIAL_COLLECTION_SIZE_LIMIT = 1 << 20;

From 99e221bff072915b95194f07c3219ac07c717e66 Mon Sep 17 00:00:00 2001
From: "nathan.xu" <nathan.xu@procor.com>
Date: Sun, 10 Nov 2024 21:43:16 -0500
Subject: [PATCH 5/5] revert back some changes

---
 hibernate-core/src/main/java/org/hibernate/sql/Delete.java      | 2 +-
 .../src/main/java/org/hibernate/sql/ForUpdateFragment.java      | 2 +-
 hibernate-core/src/main/java/org/hibernate/sql/InFragment.java  | 2 +-
 hibernate-core/src/main/java/org/hibernate/sql/Insert.java      | 2 +-
 .../src/main/java/org/hibernate/sql/NullnessRestriction.java    | 2 +-
 .../src/main/java/org/hibernate/sql/SimpleSelect.java           | 2 +-
 hibernate-core/src/main/java/org/hibernate/sql/Update.java      | 2 +-
 .../src/main/java/org/hibernate/sql/ast/package-info.java       | 2 +-
 .../java/org/hibernate/sql/ast/spi/SqlAliasBaseManager.java     | 2 +-
 .../java/org/hibernate/sql/ast/spi/SqlAstCreationState.java     | 2 +-
 .../java/org/hibernate/sql/ast/spi/SqlAstProcessingState.java   | 2 +-
 .../src/main/java/org/hibernate/sql/ast/spi/package-info.java   | 2 +-
 12 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/hibernate-core/src/main/java/org/hibernate/sql/Delete.java b/hibernate-core/src/main/java/org/hibernate/sql/Delete.java
index 8273f9e5f389..bc00167d7021 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/Delete.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/Delete.java
@@ -13,7 +13,7 @@
 import org.hibernate.sql.ast.spi.ParameterMarkerStrategy;
 
 /**
- * An SQL {@code DELETE} statement.
+ * A SQL {@code DELETE} statement.
  *
  * @author Gavin King
  */
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/ForUpdateFragment.java b/hibernate-core/src/main/java/org/hibernate/sql/ForUpdateFragment.java
index d14c0053fc81..ab048a4fd493 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/ForUpdateFragment.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/ForUpdateFragment.java
@@ -14,7 +14,7 @@
 import org.hibernate.internal.util.StringHelper;
 
 /**
- * An SQL {@code FOR UPDATE} clause.
+ * A SQL {@code FOR UPDATE} clause.
  *
  * @author Gavin King
  */
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/InFragment.java b/hibernate-core/src/main/java/org/hibernate/sql/InFragment.java
index 69a18b663d51..5a17b2ab83c7 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/InFragment.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/InFragment.java
@@ -12,7 +12,7 @@
 import org.hibernate.internal.util.StringHelper;
 
 /**
- * An SQL {@code IN} expression.
+ * A SQL {@code IN} expression.
  *
  * @author Gavin King
  */
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/Insert.java b/hibernate-core/src/main/java/org/hibernate/sql/Insert.java
index 70ca912aa055..e4dbd7d7bd7a 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/Insert.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/Insert.java
@@ -18,7 +18,7 @@
 
 
 /**
- * An SQL {@code INSERT} statement.
+ * A SQL {@code INSERT} statement.
  *
  * @author Gavin King
  */
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/NullnessRestriction.java b/hibernate-core/src/main/java/org/hibernate/sql/NullnessRestriction.java
index fd77e22e6266..b8a1dc581924 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/NullnessRestriction.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/NullnessRestriction.java
@@ -7,7 +7,7 @@
 import org.hibernate.Internal;
 
 /**
- * Nullness restriction - IS (NOT) NULL ?
+ * Nullness restriction - IS (NOT)? NULL
  *
  * @author Steve Ebersole
  */
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/SimpleSelect.java b/hibernate-core/src/main/java/org/hibernate/sql/SimpleSelect.java
index e5323621928e..4b12127d5c08 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/SimpleSelect.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/SimpleSelect.java
@@ -20,7 +20,7 @@
 import org.hibernate.sql.ast.spi.ParameterMarkerStrategy;
 
 /**
- * An SQL {@code SELECT} statement with no table joins.
+ * A SQL {@code SELECT} statement with no table joins.
  *
  * @author Gavin King
  */
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/Update.java b/hibernate-core/src/main/java/org/hibernate/sql/Update.java
index 66bce7f70e83..38fe7e62c6d3 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/Update.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/Update.java
@@ -15,7 +15,7 @@
 import org.hibernate.sql.ast.spi.ParameterMarkerStrategy;
 
 /**
- * An SQL {@code UPDATE} statement.
+ * A SQL {@code UPDATE} statement.
  *
  * @author Gavin King
  */
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/ast/package-info.java b/hibernate-core/src/main/java/org/hibernate/sql/ast/package-info.java
index c95d664490c4..8bc84339372a 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/ast/package-info.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/ast/package-info.java
@@ -6,7 +6,7 @@
  */
 
 /**
- * Package defining an SQL AST for use in generation of SQL.
+ * Package defining a SQL AST for use in generation of SQL.
  * <p>
  * The SQL AST is an intermediate product of the {@linkplain org.hibernate.query.hql process}
  * of translating a HQL or criteria query to SQL.
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAliasBaseManager.java b/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAliasBaseManager.java
index ce3ec831b35e..f419132db5a0 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAliasBaseManager.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAliasBaseManager.java
@@ -9,7 +9,7 @@
 import java.util.Set;
 
 /**
- * Helper used in creating unique SQL table aliases for an SQL AST
+ * Helper used in creating unique SQL table aliases for a SQL AST
  *
  * @author Steve Ebersole
  */
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAstCreationState.java b/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAstCreationState.java
index 9eb8163993e0..7c32e8d192d5 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAstCreationState.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAstCreationState.java
@@ -12,7 +12,7 @@
 import org.hibernate.sql.ast.tree.from.TableGroup;
 
 /**
- * Access to stuff used while creating an SQL AST
+ * Access to stuff used while creating a SQL AST
  *
  * @author Steve Ebersole
  */
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAstProcessingState.java b/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAstProcessingState.java
index f6501f9ebd29..8444146842c0 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAstProcessingState.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/SqlAstProcessingState.java
@@ -6,7 +6,7 @@
 
 /**
  * Generalized access to state information relative to the "current process" of
- * creating an SQL AST.
+ * creating a SQL AST.
  *
  * @author Steve Ebersole
  */
diff --git a/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/package-info.java b/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/package-info.java
index 18e96eee3649..772e93783fc9 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/package-info.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/package-info.java
@@ -6,6 +6,6 @@
  */
 
 /**
- * Package defining support for creating and consuming an SQL AST.
+ * Package defining support for creating and consuming a SQL AST.
  */
 package org.hibernate.sql.ast.spi;