From c2575181d14b5f0f1d32e3f040e75ad058858e41 Mon Sep 17 00:00:00 2001
From: marko-bekhta <marko.prykladna@gmail.com>
Date: Thu, 10 Nov 2022 13:37:30 +0100
Subject: [PATCH] HSEARCH-4712 Add checkstyle rules to detect sync blocks to be
 replaced

---
 build/config/src/main/resources/checkstyle.xml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/build/config/src/main/resources/checkstyle.xml b/build/config/src/main/resources/checkstyle.xml
index 4c67ebff575..80611ef48a3 100644
--- a/build/config/src/main/resources/checkstyle.xml
+++ b/build/config/src/main/resources/checkstyle.xml
@@ -94,6 +94,13 @@
             <property name="ignoreComments" value="true" />
         </module>
 
+        <!-- Do not use sync blocks on objects -->
+        <module name="RegexpSinglelineJava">
+            <property name="format" value="synchronized\s*\(\s*(?!this\b)\w+" />
+            <property name="message" value="Do not use `synchronized (someObject)` blocks. Instead use the `java.util.concurrent.locks.Lock`s. See HSEARCH-4712." />
+            <property name="ignoreComments" value="true" />
+        </module>
+
        <!-- Checks for imports -->
         <module name="AvoidStarImport" />
         <module name="RedundantImport" />