HSEARCH-4061 Clarify the purpose of Maven property 'version.legacy.ju…

…nit' Signed-off-by: Yoann Rodière <yoann@hibernate.org>
hibernate · Oct 20, 2020 · d0dec76 · d0dec76
1 parent d1b9d46
commit d0dec76
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/integrationtest/showcase/library/pom.xml b/integrationtest/showcase/library/pom.xml
@@ -44,10 +44,16 @@
                     </exclusion>
                 </exclusions>
             </dependency>
+            <!--
+                junit-vintage-engine 5.5.2 version does not support junit 4.13.1.
+                If we try to use it, a parsing error is thrown.
+                So we downgrade JUnit, so that junit-vintage-engine will handle it.
+                See https://stackoverflow.com/a/64371503/1812965
+            -->
             <dependency>
                 <groupId>junit</groupId>
                 <artifactId>junit</artifactId>
-                <version>${version.legacy.junit}</version>
+                <version>${version.junit.junit-platform-workaround}</version>
                 <scope>test</scope>
             </dependency>
         </dependencies>

diff --git a/pom.xml b/pom.xml
@@ -252,8 +252,9 @@
             junit-vintage-engine 5.5.2 version does not support junit 4.13.1.
             If we try to use it, a parsing error is thrown.
             So we downgrade JUnit, so that junit-vintage-engine will handle it.
+            See https://stackoverflow.com/a/64371503/1812965
         -->
-        <version.legacy.junit>4.13</version.legacy.junit>
+        <version.junit.junit-platform-workaround>4.13</version.junit.junit-platform-workaround>
 
         <version.org.hamcrest>2.2</version.org.hamcrest>
         <version.org.mockito>3.5.13</version.org.mockito>