Permalink
Commits on May 26, 2017
  1. HSEARCH-2746 Translate parameters of WordDelimiterFilterFactory from …

    …0/1 to booleans on Elasticsearch
    yrodiere committed with Sanne May 24, 2017
Commits on May 24, 2017
Commits on May 23, 2017
  1. HSEARCH-2726 Remove a redundant test

    AnalyzerBuilderTest.testAnalyzerDef only re-tests something we already
    check in AnalyzerBuilderIndexingTest.
    yrodiere committed May 18, 2017
  2. HSEARCH-2726 Move Elasticsearch analyzer definition ITs to separate c…

    …lasses
    
    This reduces code duplication in tests (since the tests are identical in
    ES 2 and ES 5), and hopefully will make the addition of
    normalizer-related tests easier.
    yrodiere committed May 18, 2017
Commits on May 22, 2017
  1. HSEARCH-2737 Agents usage during builds requires a new JVM flag on JDK 9

    Since recent preview builds of OpenJDK 9 agents such as Byteman are no longer allowed to auto-attach to the JVM at runtime.
    This needs a new (read-only) property to be set before boot: -Djdk.attach.allowAttachSelf=true
    Sanne committed May 22, 2017
Commits on May 19, 2017
  1. HSEARCH-2736 Add a *disabled* test for hibernate.search.default.elast…

    …icsearch.discovery.default_scheme
    
    See HSEARCH-2481 for why it's disabled.
    Byteman is probably our only solution here. We don't have a valid SSL
    certificate to put in the Elasticsearch server mock, so every HTTPS call
    will fail. Worse, the failure will be exactly the same when using HTTP
    instead of HTTPS (ConnectionClosedException).
    yrodiere committed May 19, 2017
  2. HSEARCH-2736 Discovery_scheme not taken in account

    Fix deprecation on flag discovery_scheme for https support
    mvincent committed with yrodiere May 19, 2017
Commits on May 17, 2017
Commits on May 16, 2017
  1. HSEARCH-1316 Protect all state depending on the Integrator consistently

    The FullTextIndexEventListener has several more fields which depend on the
    initialization of the final ExtendedSearchIntegrator, this patch is making
    sure that any such necessary state is accessed consistently and via the
    required visibility guards.
    
    There's something dodgy going on with Serializability of this class but that
    appears to be a problem we already had.
    Sanne committed May 16, 2017
  2. HSEARCH-1316 Allow BeanResolver implementations to return null to fal…

    …l back to reflection
    
    This allow integrators to only provide bean resolution for a subset of
    beans, for instance those with a pre-defined annotation, and still not
    interfere with other beans required by Hibernate Search.
    yrodiere committed with Sanne Mar 29, 2017
  3. HSEARCH-1316 Allow integrators to defer the initialization of the sea…

    …rch factory using a provided EnvironmentSynchronizer
    
    This is necessary to integrate with CDI on WildFly in particular.
    
    When WildFly starts Hibernate ORM, the CDI context has already
    been bootstrapped, but it hasn't been initialized, so one cannot request
    beans yet. The CDI context will only get fully initialized *after* Hibernate
    ORM has finished starting.
    
    When we want to provide a CDI implementation of BeanResolver, this
    creates a cyclic dependency: Hibernate Search needs the BeanResolver to
    be available when it starts, but the BeanResolver needs CDI to be
    initialized, and CDI won't be initialized before Hibernate ORM has
    started, which won't happen before Hibernate Search has started.
    
    The EnvironmentSynchronizer provides a way to break this cyclic
    dependency, by defering the initialization of Hibernate Search to when
    CDI is fully initialized. If Search is accessed (either to index
    entities or to execute search queries) before that, the calls will just
    block.
    yrodiere committed with Sanne Mar 29, 2017
  4. HSEARCH-1316 Fix the error message when a class bridge cannot be dete…

    …rmined
    
    Giving ClassBridge.class.getName() in the error log is useless, what we
    want is to provide a hint as to *which* class bridge has a problem.
    yrodiere committed with Sanne Mar 24, 2017
  5. HSEARCH-1316 Introduce the BeanResolver, allowing to plug in external…

    … bean resolution mechanisms
    yrodiere committed with Sanne Mar 21, 2017
  6. HSEARCH-1316 Move Spring JTA ITs to a subpackage of org.hibernate.sea…

    …rch.test.integration.spring
    yrodiere committed with Sanne Mar 21, 2017
  7. HSEARCH-1316 Remove the most obviously irrelevant custom values for c…

    …onfiguration options in Spring ITs
    yrodiere committed with Sanne Mar 16, 2017
  8. HSEARCH-2583 Avoid duplicated documentation about @Factory in the jav…

    …adoc
    
    More precisely, only mention the requirement for implementations to
    either have a no-arg constructor or a @Factory-annotated method in
    places where we actually need users to provide an implementation.
    yrodiere committed with Sanne May 11, 2017
  9. Fix typos in the documentation

    yrodiere committed with Sanne May 11, 2017
  10. HSEARCH-2721 Fix transient failures in DefaultElasticsearchClientFact…

    …oryTest.discovery
    
    Below is a description of the method I followed to check that the fix is effective.
    
    * run this shell code before making any change:
    function countFailures() {
    	FAILURE=0
    	SUCCESS=0;
    	while true
    	do
    		if eval "${@}" 1>/dev/null 2>&1
    		then
    			(( ++ SUCCESS ))
    		else
    			(( ++ FAILURE ))
    		fi
    		echo "Success: $SUCCESS, failure: $FAILURE"
    	done
    }
    mvn clean install -DskipTests=true
    countFailures mvn test -pl elasticsearch -rf elasticsearch "-Dtest=DefaultElasticsearchClientFactoryTest#discovery"
    * notice that for 50 runs, you get approximately 5 failures
    * apply the changes in this commit
    * run the same shell code again
    * notice that you don't get any failures even after 50 runs
    yrodiere committed with Sanne May 12, 2017