New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HSEARCH-2188 Fixed type checking in NumericFieldUtilsTest #1046
Conversation
Can one of the admins add this person to the trusted builders? (reply with: "add to whitelist" or "ok to test") |
ok to test |
thanks @gfouquet ! I'll gladly apply your patches, but could you please sign the Hibernate contribution agreement? |
Hi, |
value instanceof Long || | ||
value instanceof Integer || | ||
value instanceof Float || | ||
value instanceof Calendar; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, I'm surprised this is not consistent with the code above. Shouldn't we also have Byte, Date and Short here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. Sounds reasonable to me to have Byte, Date and Short here as well.
Where are we with this one? |
I'm willing to make any change the Hibernate team see fit. On the other hand I'm mostly clueless about the side effects of any change. |
@gunnarmorling it's already fixed in master for a while and I extracted the test case and the additional cleanup from Gregory's PR and pushed it to master: a5ad4f5 I asked @Sanne if we still maintain 5.3 and 5.4 but I haven't had a reply so far. If we do, I'll prefer to only cherrypick Davide's commit fixing this: 4c0415c . No need for the further cleanup in the old branches. |
@gfouquet I will backport Davide's fix in 5.3 and 5.4. That being said, we haven't planned to release new versions of these 2 branches. |
OK, so I pushed the test and the cleanup to master a few weeks ago and backported the original Davide's fix to 5.3 and 5.4 just now. Closing. Thanks! |
isAssignableFrom
inNumericFieldUtils
was used the wrong way. I turned it around and added a unit test, which did not pass with the previous implementation.