Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor improvements #1134

Merged
merged 4 commits into from Aug 5, 2016

Conversation

Projects
None yet
2 participants

@gsmet gsmet self-assigned this Aug 3, 2016

return concurrentStack.removeFirst();
}
catch (java.util.NoSuchElementException nse) {
throw new IllegalStateException( "Attempted to consume an event, while no events were recorded. Check if the Byteman ruless actually triggered?" );

This comment has been minimized.

Copy link
@gsmet

gsmet Aug 3, 2016

Member

I think the new message is misleading. I would have made it:
"Attempted to consume an event, while no events are left. If it is the first call to this method, check if the Byteman rules are actually triggered?"

The fact is that you have the same error if you have consumed too many events.

This comment has been minimized.

Copy link
@Sanne

Sanne Aug 5, 2016

Author Member

good point, thanks I'll change it. Ok to push beyond that?

@Sanne Sanne force-pushed the Sanne:BytemanResilience branch from b53537a to 9a06c8b Aug 5, 2016

@gsmet gsmet merged commit 9a06c8b into hibernate:master Aug 5, 2016

1 check passed

default Build finished. 1599 tests run, 2 skipped, 0 failed.
Details
@gsmet

This comment has been minimized.

Copy link
Member

commented Aug 5, 2016

Merged! Thanks!

@Sanne Sanne deleted the Sanne:BytemanResilience branch Aug 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.