Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
HSEARCH-2576 FacetingManager should allocate maps lazily #1306
I have been busy with performance testing, but actually not (yet) with Infinispan..
It's actually amazing what a difference this small change makes: we have a flaw in our container based performance tests, which triggers an occasional deadlock in H2 when we're "too fast". After this change, that test fails much more frequently (from "almost never" to "almost all the time" .. on my pc at least).
So you used the existing performance testing project from our own code? Great :)
I suppose there's no way to fix this? Maybe upgrade H2? It would be a shame if, after merging this PR, our CI became useless because it would always fail...
Yes, let's keep an eye on this.. I hope not as CI is quite slow. let's not upgrade it! :D More seriously, yes fixing the test is on my watchlist..
I have some more perf tests as well, being developed. Will need to tidy them up eventually and share, it's currently a mess of experiments and various branches trying different things, e.g. different combinations of dependencies.
Moving ahead we'd want to have nightly performance regression reports built by CI.