Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
HSEARCH-3498 Move optional predicate DSL parameters to the terminal contexts #1917
Pull Request Test Coverage Report for Build 6
fax4ever left a comment
I think that changes here are OK. I've spent some time seeking if it would be possible to avoid the new generic on
The issue mentions (see Pros#3) that we would be able to do more validations, such as validate fuzzy is not applied to an Integer field. Do we have some tests for these cases?
Moreover, I was thinking that maybe it would be nice change
I addressed some comments. Here are my answers:
It's not about making more validations, since we already had this validation. It's about throwing the exception at the right time, i.e. when
Not sure it's a great name, but feel free to create a ticket so that we think about it.