HSEARCH-3099 HSEARCH-3553 Restore support for "indexNullAs" in @Field #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fax4ever
force-pushed
the
3099-make-index-null-as
branch
5 times, most recently
from
0d5abcb
to
c14df18
Compare
fax4ever
force-pushed
the
3099-make-index-null-as
branch
from
f4823d1
to
638c76d
Compare
fax4ever
changed the title
yrodiere
requested changes
Apr 15, 2019
There was a problem hiding this comment.
My comments below. I disagree with a few details in the backend side of the implementation, but in my opinion the most important problem is the lack of coverage and extensibility of the mapper side of the implementation: it limits support to just a few primitive types, even though we used to support much more in Search 5, and it completely bars the way to users defining their own parsing method for custom bridges.
...backend/elasticsearch/types/dsl/impl/AbstractElasticsearchTemporalIndexFieldTypeContext.java
Outdated
Show resolved
Hide resolved
...e/search/backend/elasticsearch/types/dsl/impl/ElasticsearchBooleanIndexFieldTypeContext.java
Outdated
Show resolved
Hide resolved
...nate/search/backend/elasticsearch/types/dsl/impl/ElasticsearchByteIndexFieldTypeContext.java
Outdated
Show resolved
Hide resolved
...te/search/backend/elasticsearch/types/dsl/impl/ElasticsearchDoubleIndexFieldTypeContext.java
Outdated
Show resolved
Hide resolved
...ate/search/backend/elasticsearch/types/dsl/impl/ElasticsearchFloatIndexFieldTypeContext.java
Outdated
Show resolved
Hide resolved
...mapper/pojo/mapping/definition/programmatic/impl/PropertyGenericFieldMappingContextImpl.java
Outdated
Show resolved
Hide resolved
.../org/hibernate/search/integrationtest/mapper/pojo/mapping/definition/IndexNullAsValueIT.java
Outdated
Show resolved
Hide resolved
...ernate/search/backend/lucene/types/dsl/impl/AbstractLuceneStandardIndexFieldTypeContext.java
Outdated
Show resolved
Hide resolved
...java/org/hibernate/search/backend/lucene/document/model/impl/LuceneIndexSchemaFieldNode.java
Outdated
Show resolved
Hide resolved
...a/org/hibernate/search/integrationtest/mapper/orm/mapping/definition/IndexNullAsValueIT.java
Outdated
Show resolved
Hide resolved
fax4ever
changed the title
fax4ever
force-pushed
the
3099-make-index-null-as
branch
3 times, most recently
from
f3e3307
to
8675b7e
Compare
fax4ever
force-pushed
the
3099-make-index-null-as
branch
2 times, most recently
from
c3e8fc8
to
f991d89
Compare
fax4ever
force-pushed
the
3099-make-index-null-as
branch
from
f991d89
to
a3506f5
Compare
|
@yrodiere, thanks for the in depth review. I think I've addressed most of the suggestions. |
yrodiere
reviewed
Apr 18, 2019
There was a problem hiding this comment.
Nearly there!
I have a few optional comments below. Feel free to ignore them, but one thing that is still missing is the documentation.
I can do it if you prefer, but I think we should add:
- Something about
indexNullAsin mapping annotations. Seemapper-orm-mapping.asciidoc, section "Direct field mapping". You can add an item in the definition list at the very bottom of that section, after "projectable". It's not worth your time to add an example, one or two sentences should be enough since the feature is rather straightforward (to use... I know it's been hard to implement :) ). - Something about how
indexNullAsin mapping annotations is parsed for each built-in value bridge. Seemapper-orm-mapping.asciidoc, section "Built-in value bridges". You can add a column "Parsing method for 'indexNullAs'" to the right of the table. Personally I would simply put something likeZoneOffset.parse(String)in most cases.
...main/java/org/hibernate/search/integrationtest/backend/tck/indexnull/IndexNullAsValueIT.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/org/hibernate/search/engine/cfg/spi/ParseUtils.java
Show resolved
Hide resolved
...bernate/search/mapper/pojo/mapping/building/impl/FieldModelContributorBridgeContextImpl.java
Outdated
Show resolved
Hide resolved
...in/java/org/hibernate/search/mapper/pojo/mapping/building/impl/PojoIndexModelBinderImpl.java
Outdated
Show resolved
Hide resolved
...mapper/pojo/mapping/definition/annotation/impl/PropertySortableFieldAnnotationProcessor.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/org/hibernate/search/engine/logging/impl/Log.java
Outdated
Show resolved
Hide resolved
yrodiere
approved these changes
Apr 18, 2019
fax4ever
force-pushed
the
3099-make-index-null-as
branch
from
1a573dd
to
3c9e717
Compare
|
Thank you @yrodiere. Is there other we can improve? |
fax4ever
force-pushed
the
3099-make-index-null-as
branch
from
3c9e717
to
7b19987
Compare
|
It looks good; I pushed a few commits with minor fixes and will merge as soon as CI goes green. |
|
Hi @yrodiere! Seen the fixes, they are good for me. Thank you ;) |
…ration, Period Rather than exposing the internal format. This is consistent with what we do for the character bridge in particular, or the URI/URL bridges, or the Enum bridge, or the ZoneId bridge: we expect a string representing the type seen from the user side, not the indexed type.
yrodiere
force-pushed
the
3099-make-index-null-as
branch
from
5ecebd4
to
e2a158a
Compare
|
Merged. Thanks a lot! |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HSEARCH-3099
https://hibernate.atlassian.net/browse/HSEARCH-3553