HSEARCH-3582 Make the build compatible with Eclipse #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1
💛 - Coveralls |
…idgeExplicitReindexingFunctionalIT
…chQueryResultContext They trigger compilation errors in Eclipse, and they really aren't necessary.
It will only be executed for the master and maintenance branches, not for PRs or feature branches.
…to build environment rather than IT environment Because the JDK and compiler are not (only) about ITs.
…environment that doesn't require default build artifacts is run
|
Checked on Eclipse, it works. I'll merge and adjust if @gsmet runs into any problem while developing on Eclipse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net//browse/HSEARCH-3582
I took this opportunity to improve the Jenkinsfile a little bit, allowing to run the build in an arbitrary environment using a new "ENVIRONMENT_FILTER" parameter. I used it to run only the part of the build checking that the eclipse compiler works fine, see here: http://ci.hibernate.org/job/hibernate-search-yoann/job/HSEARCH-3582/25/