Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
HSEARCH-3609 Replace bridge builders with *binders* #2034
This is an attempt at making the bridge 2.0 API simpler for simple use cases, and not-too-complicated-yet-powerful for advanced use cases.
Due to the refactorings involved, this will not be easy to review, so I'll describe the result here instead. If that doesn't seem too bad to you, I'll merge. Then I'll work on documenting this... soon-ish...
Simple use case:
3 times, most recently
Jul 8, 2019
@fax4ever I just pushed an additional commit to address a problem that @gsmet mentioned to me: the cast() method in Value and Identifier bridges was not necessary anymore, since after this PR the binders are expected to pass the expected type of values/identifiers to Hibernate Search, so we can perform the cast ourselves.