Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
HSEARCH-3441 + HSEARCH-3623 Improve naming consistency of DSL/builder methods #2070
…sis definition DSLs They were deprecated two releases ago, in 6.0.0.Alpha8. The only removed "feature" is the ability to chain analyzer definitions in the Lucene analysis definition DSL, which was deprecated as part of 6.0.0.Alpha8. This is more consistent with the Elasticsearch analysis definition DSL.
* withConstantScore() => constantScore() * boostedTo(float) => boost(float) * withAndAsDefaultOperator() => defaultOperator(BooleanOperator.AND) * withSlop(int) => slop(int) Old methods were deprecated, not removed.
…c mapping DSL For consistency with pretty much every other method in this DSL and other DSLs.
…ods in the predicate DSL For consistency with the projection, sort and aggregation DSLs. One big advantage is that calls to .field() no longer give the impression that the predicate will match if *any* field matches. This is currently true, but there are plans to provide options to tune this: https://hibernate.atlassian.net/browse/HSEARCH-3327
yrodiere merged commit
Sep 9, 2019
3 of 4 checks passed
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.