HSEARCH-3729 Give more information about failures to MassIndexer users #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrodiere
added
the
Waiting for other pull request
fax4ever
approved these changes
Dec 18, 2019
This feature is not complex enough to warrant a dedicated package.
... so that we can test a custom MassIndexingFailureHandler more easily.
…ingFailureIT So as to make the test simpler.
yrodiere
force-pushed
the
HSEARCH-3729
branch
from
aa135e1
to
f8ec95a
Compare
|
Thanks. I just rebased on master. I will merge as soon as CI goes green. |
yrodiere
added
+1 just push it!
and removed
Waiting for other pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HSEARCH-3729
Based on #2172 , which should be merged first.