Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSEARCH-4130 Use docker containers for Elasticsearch in integration tests #2539

Merged
merged 4 commits into from Apr 14, 2021

Conversation

fax4ever
Copy link
Contributor

@fax4ever fax4ever commented Apr 5, 2021

@yrodiere
Copy link
Member

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good overall, though I have a few comments

parents/integrationtest/pom.xml Show resolved Hide resolved
parents/integrationtest/pom.xml Outdated Show resolved Hide resolved
parents/integrationtest/pom.xml Outdated Show resolved Hide resolved
parents/integrationtest/pom.xml Show resolved Hide resolved
parents/integrationtest/pom.xml Show resolved Hide resolved
parents/integrationtest/pom.xml Show resolved Hide resolved
pom.xml Show resolved Hide resolved
@fax4ever
Copy link
Contributor Author

fax4ever commented Apr 14, 2021

Thanks. I think I made the changes, even if I don't see the Outdated labels on the comments.
Anything else to improve/fix here?

@fax4ever
Copy link
Contributor Author

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment. Feel free to merge once it's addressed and the full build passes. Thanks.

Jenkinsfile Outdated
@@ -800,10 +795,6 @@ class EsLocalBuildEnvironment extends BuildEnvironment {
String jdkTool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this can be removed as well. Don't forget to remove it in the calls to new EsLocalBuildEnvironment as well.

@fax4ever
Copy link
Contributor Author

Run another full build (just to be sure it works): https://ci.hibernate.org/blue/organizations/jenkins/hibernate-search/detail/PR-2539/9/pipeline

@sonarcloud
Copy link

sonarcloud bot commented Apr 14, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fax4ever fax4ever merged commit 04930e9 into hibernate:main Apr 14, 2021
@fax4ever
Copy link
Contributor Author

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants