New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HSEARCH-4130 Use docker containers for Elasticsearch in integration tests #2539
Conversation
Started a full build here: https://ci.hibernate.org/blue/organizations/jenkins/hibernate-search/detail/PR-2539/3/pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good overall, though I have a few comments
Thanks. I think I made the changes, even if I don't see the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment. Feel free to merge once it's addressed and the full build passes. Thanks.
Jenkinsfile
Outdated
@@ -800,10 +795,6 @@ class EsLocalBuildEnvironment extends BuildEnvironment { | |||
String jdkTool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this can be removed as well. Don't forget to remove it in the calls to new EsLocalBuildEnvironment
as well.
I don't know if there exists a way to port them to the Docker version
Run another full build (just to be sure it works): https://ci.hibernate.org/blue/organizations/jenkins/hibernate-search/detail/PR-2539/9/pipeline |
Kudos, SonarCloud Quality Gate passed! |
Merged, thanks! |
https://hibernate.atlassian.net/browse/HSEARCH-4130