Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Some very minor improvements in Search + docs #275

Closed
wants to merge 9 commits into
from

Conversation

Projects
None yet
3 participants
Owner

Sanne commented Apr 23, 2012

  • HSEARCH-1104 Remove warnings about experimental features which are no longer experimental
  • HSEARCH-1094 Typo method name SearchMapping#getFullTextFilerDefs

@ghost ghost assigned hferentschik Apr 24, 2012

Owner

hferentschik commented Apr 24, 2012

Nice, this cleanup was overdue :-)

Owner

emmanuelbernard commented Apr 24, 2012

The doc looks good. As I said, I'm tempted to remove this barely used method with the typo right now to reduce pain in the world. WDYT?

Owner

hferentschik commented Apr 24, 2012

As I said, I'm tempted to remove this barely used method with the typo right now to reduce pain in the world. WDYT?

The proper way of doing this is via deprecation, but I could also be convinced to just remove it. @Sanne !?

Owner

Sanne commented Apr 24, 2012

rewriting here as I had answered on the commit (for sake @hferentschik )

Same here, I was tempted to remove it right away but opted to do "the right thing" even if I wasn't convinced about it to be safe.
After the fact while cleaning up the "experimental" warnings, I realized this API was experimental (until right now), so I agree let's just fix it.

pull request rewritten

Owner

hferentschik commented Apr 24, 2012

Applied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment