Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEARCH-1264 Document usage of JBoss AS 7 module #378

Closed
wants to merge 1 commit into from

Conversation

DavideD
Copy link
Member

@DavideD DavideD commented Jan 24, 2013

@@ -180,6 +180,65 @@ mvn archetype:generate \
</section>

<section>
<title>Using JBoss Modules</title>

<para>Provided you're deploying on JBoss 7.1.x or EAP6, there is an additional way to add the search dependencies to your application.</para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to spell it out fully then it should be JBoss AS 7.1.x or JBoss EAP6

@Sanne
Copy link
Member

Sanne commented Jan 27, 2013

thanks. weird I didn't see the notification from your last change, I just happened to browse here to have another look.

<term>Using the manifest</term>
<listitem>
<para>Add this entry to the MANIFEST.MF in your archive:</para>
<programlisting>Dependencies org.hibernate.search.orm services</programlisting>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested.. it's actually wrong :)
should be:

Dependencies: org.hibernate.search.orm services

note the separator between the attribute key and value: ":"

@DavideD
Copy link
Member Author

DavideD commented Jan 27, 2013

Fixed, ":" added

@Sanne
Copy link
Member

Sanne commented Jan 28, 2013

note the JIRA code is HSEARCH, not SEARCH.
The sourceforge link was not going to work, it needs to be httpS
I've added a section label, that provides nice linkable anchors in the docs.

merged

@Sanne Sanne closed this Jan 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants