HSEARCH-1120 Added a hibernate search module for EAP 6.1.0.Alpha1 #390

Closed
wants to merge 1 commit into from

2 participants

@hchiorean

The EAP 6.1.0 module was added alongside the existing AS 7.1.1 kit (to avoid breaking any clients which use this module currently).

However, because EAP 6.1.0.Alpha1 dist is not available in any Maven repository I was unable to add an integration test for the new kit. Rather, I tested it by deploying it manually in ModeShape's kit and running ModeShape's integration tests.

When https://hibernate.atlassian.net/browse/HSEARCH-1286 is fixed, an additional integration test can be added which validates the module. As a side-note, for ModeShape we went "to great lengths" to be able to run the integration tests using EAP 6.1.0.Alpha1. Currently we have 2 mandatory steps:

  • each developer/contributor has to install locally on his/her machine using mvn install:install-file the download EAP dist zip
  • an additional Maven repository URL was added to our settings.xml file to be able to locate the other EAP 6.1.0. components.
@hchiorean

@Sanne: I logged the PR under HSEARCH-1120 (which is closed atm) because I didn't find another JIRA issue. If there is another one, I can rename/re-push/amend the commit so it can be traced to the correct JIRA issue.

@Sanne
Hibernate member

hI @hchiorean , did you see the other pull request open as well?
#388

it wasn't merged yet as it's easter holidays for the rest of the team, I'm sorry as it's both conflicting and duplicating some work.
The good news: I found a way to test against almost-EAP61 using the preview repository.. please have a look at the other pull?

@Sanne
Hibernate member

Also, did you not have problems without a fix for https://hibernate.atlassian.net/browse/HSEARCH-1289 ?
(included in the other pull as well)

@hchiorean

This #388 looks good and the hsearch module.xml is pretty much what we're using right now.

The only difference from the ModeShape kit is that originally we deployed our modules in system/layers/base but then we reverted back to the "old" /modules, which also works. It's yet unclear (to me & to other people as well) what the "appropriate" location should be.

Regarding https://hibernate.atlassian.net/browse/HSEARCH-1289 - we haven't stumbled across it.

Closing this PR as it is superseded by the one mentioned above.

@hchiorean hchiorean closed this Apr 1, 2013
@Sanne
Hibernate member

@hchiorean Do I need to apply any change from your modules? I'm happy to adapt my pull as/if needed to take the best of two worlds.

@hchiorean

@Sanne no, based on the changes that I've seen in your PR, everything we need is there.

The only open discussion is around the location: system/layers/base versus /modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment