Skip to content

Do not quote catalog when add it to mapping #20

Closed
wants to merge 2 commits into from

3 participants

@dgeraskov

This fixes https://issues.jboss.org/browse/JBIDE-11227

Note there is still a problem with Hierbate ddl generation https://hibernate.onjira.com/browse/HHH-7195

@maxandersen
Hibernate member

Not quoting catalog and still quoting schema is inconsistent.

This can't be the right fix.

Got a junit test to back this up ?

@dgeraskov

Added junit test. Please do not forget to switch properties to h2 to check.

@maxandersen
Hibernate member

The new test just tests when there is a '.', how about the case where there is a space in the catalog name - removing quoting would harm that case.

@maxandersen
Hibernate member

Do not believe this is a proper fix for this issue.

@koentsje
Hibernate member

I'm closing this pull request as it doesn't seem to solve the issue completely

@koentsje koentsje closed this Sep 13, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.