Do not quote catalog when add it to mapping #20

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
@dgeraskov
Contributor

dgeraskov commented Mar 22, 2012

This fixes https://issues.jboss.org/browse/JBIDE-11227

Note there is still a problem with Hierbate ddl generation https://hibernate.onjira.com/browse/HHH-7195

@maxandersen

This comment has been minimized.

Show comment
Hide comment
@maxandersen

maxandersen Mar 22, 2012

Not quoting catalog and still quoting schema is inconsistent.

This can't be the right fix.

Got a junit test to back this up ?

Not quoting catalog and still quoting schema is inconsistent.

This can't be the right fix.

Got a junit test to back this up ?

@dgeraskov

This comment has been minimized.

Show comment
Hide comment
@dgeraskov

dgeraskov Mar 26, 2012

Contributor

Added junit test. Please do not forget to switch properties to h2 to check.

Contributor

dgeraskov commented Mar 26, 2012

Added junit test. Please do not forget to switch properties to h2 to check.

@maxandersen

This comment has been minimized.

Show comment
Hide comment
@maxandersen

maxandersen Sep 4, 2012

Member

The new test just tests when there is a '.', how about the case where there is a space in the catalog name - removing quoting would harm that case.

Member

maxandersen commented Sep 4, 2012

The new test just tests when there is a '.', how about the case where there is a space in the catalog name - removing quoting would harm that case.

@maxandersen

This comment has been minimized.

Show comment
Hide comment
@maxandersen

maxandersen Sep 4, 2012

Member

Do not believe this is a proper fix for this issue.

Member

maxandersen commented Sep 4, 2012

Do not believe this is a proper fix for this issue.

@koentsje

This comment has been minimized.

Show comment
Hide comment
@koentsje

koentsje Sep 13, 2012

Member

I'm closing this pull request as it doesn't seem to solve the issue completely

Member

koentsje commented Sep 13, 2012

I'm closing this pull request as it doesn't seem to solve the issue completely

@koentsje koentsje closed this Sep 13, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment