From 0271b10b76641269ba40a61f137be239cdaa7a9f Mon Sep 17 00:00:00 2001 From: kevinpollet Date: Wed, 20 Oct 2010 16:18:01 +0200 Subject: [PATCH 1/8] HV-391 Remove LocalTime test for PastValidatorForAbstractPartial. --- .../impl/PastValidatorForAbstractPartialTest.java | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/PastValidatorForAbstractPartialTest.java b/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/PastValidatorForAbstractPartialTest.java index 186fe07db5..be788884f7 100644 --- a/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/PastValidatorForAbstractPartialTest.java +++ b/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/PastValidatorForAbstractPartialTest.java @@ -60,17 +60,6 @@ public void testIsValidForLocalDate() { Assert.assertFalse( validator.isValid( future, null ) ); } - @Test - public void testIsValidForLocalTime() { - LocalTime future = new LocalTime().plusHours( 1 ); - LocalTime past = new LocalTime().minusHours( 1 ); - - Assert.assertTrue( validator.isValid( null, null ) ); - Assert.assertTrue( validator.isValid( past, null ) ); - Assert.assertFalse( validator.isValid( new LocalTime(), null ) ); - Assert.assertFalse( validator.isValid( future, null ) ); - } - @Test public void testIsValidForLocalDateTime() { LocalDateTime future = new LocalDateTime().plusYears( 1 ); From 6adb04148316dcdb088e5004b7fe7400f2108e8a Mon Sep 17 00:00:00 2001 From: kevinpollet Date: Wed, 20 Oct 2010 16:20:17 +0200 Subject: [PATCH 2/8] HV-391 Remove LocalTime test for FutureValidatorForAbstractPartial. --- .../impl/FutureValidatorForAbstractPartialTest.java | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/FutureValidatorForAbstractPartialTest.java b/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/FutureValidatorForAbstractPartialTest.java index 5f347a3e6f..d8bb8ee273 100644 --- a/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/FutureValidatorForAbstractPartialTest.java +++ b/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/FutureValidatorForAbstractPartialTest.java @@ -19,7 +19,6 @@ import junit.framework.Assert; import org.joda.time.LocalDate; import org.joda.time.LocalDateTime; -import org.joda.time.LocalTime; import org.joda.time.Partial; import org.testng.annotations.BeforeClass; import org.testng.annotations.Test; @@ -60,17 +59,6 @@ public void testIsValidForLocalDate() { Assert.assertFalse( validator.isValid( past, null ) ); } - @Test - public void testIsValidForLocalTime() { - LocalTime future = new LocalTime().plusHours( 1 ); - LocalTime past = new LocalTime().minusHours( 1 ); - - Assert.assertTrue( validator.isValid( null, null ) ); - Assert.assertTrue( validator.isValid( future, null ) ); - Assert.assertFalse( validator.isValid( new LocalTime(), null ) ); - Assert.assertFalse( validator.isValid( past, null ) ); - } - @Test public void testIsValidForLocalDateTime() { LocalDateTime future = new LocalDateTime().plusYears( 1 ); From 4598f4c8943a46ca2e133ad41440263373c657f8 Mon Sep 17 00:00:00 2001 From: kevinpollet Date: Wed, 20 Oct 2010 16:24:15 +0200 Subject: [PATCH 3/8] HV-391 Review tests assertions for PastValidatorForAbstractPartial. --- .../constraints/impl/PastValidatorForAbstractPartialTest.java | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/PastValidatorForAbstractPartialTest.java b/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/PastValidatorForAbstractPartialTest.java index be788884f7..faaee4b115 100644 --- a/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/PastValidatorForAbstractPartialTest.java +++ b/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/PastValidatorForAbstractPartialTest.java @@ -19,7 +19,6 @@ import junit.framework.Assert; import org.joda.time.LocalDate; import org.joda.time.LocalDateTime; -import org.joda.time.LocalTime; import org.joda.time.Partial; import org.testng.annotations.BeforeClass; import org.testng.annotations.Test; @@ -45,7 +44,6 @@ public void testIsValidForPartial() { Assert.assertTrue( validator.isValid( null, null ) ); Assert.assertTrue( validator.isValid( past, null ) ); - Assert.assertFalse( validator.isValid( new LocalDate(), null ) ); Assert.assertFalse( validator.isValid( future, null ) ); } @@ -56,7 +54,6 @@ public void testIsValidForLocalDate() { Assert.assertTrue( validator.isValid( null, null ) ); Assert.assertTrue( validator.isValid( past, null ) ); - Assert.assertFalse( validator.isValid( new LocalDate(), null ) ); Assert.assertFalse( validator.isValid( future, null ) ); } @@ -67,7 +64,6 @@ public void testIsValidForLocalDateTime() { Assert.assertTrue( validator.isValid( null, null ) ); Assert.assertTrue( validator.isValid( past, null ) ); - Assert.assertFalse( validator.isValid( new LocalDateTime(), null ) ); Assert.assertFalse( validator.isValid( future, null ) ); } } From 9476dfa2e65625ab4e24e853d1d20db383e4a86e Mon Sep 17 00:00:00 2001 From: kevinpollet Date: Wed, 20 Oct 2010 16:28:06 +0200 Subject: [PATCH 4/8] HV-391 Review tests assertions for FutureValidatorForAbstractPartial. --- .../impl/FutureValidatorForAbstractPartialTest.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/FutureValidatorForAbstractPartialTest.java b/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/FutureValidatorForAbstractPartialTest.java index d8bb8ee273..c3108ccbbc 100644 --- a/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/FutureValidatorForAbstractPartialTest.java +++ b/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/FutureValidatorForAbstractPartialTest.java @@ -44,7 +44,6 @@ public void testIsValidForPartial() { Assert.assertTrue( validator.isValid( null, null ) ); Assert.assertTrue( validator.isValid( future, null ) ); - Assert.assertFalse( validator.isValid( new LocalDate(), null ) ); Assert.assertFalse( validator.isValid( past, null ) ); } @@ -55,7 +54,6 @@ public void testIsValidForLocalDate() { Assert.assertTrue( validator.isValid( null, null ) ); Assert.assertTrue( validator.isValid( future, null ) ); - Assert.assertFalse( validator.isValid( new LocalDate(), null ) ); Assert.assertFalse( validator.isValid( past, null ) ); } @@ -66,7 +64,6 @@ public void testIsValidForLocalDateTime() { Assert.assertTrue( validator.isValid( null, null ) ); Assert.assertTrue( validator.isValid( future, null ) ); - Assert.assertFalse( validator.isValid( new LocalDateTime(), null ) ); Assert.assertFalse( validator.isValid( past, null ) ); } } From 522f7f1482ff0daaa3f4c8c745f5b4f9db6fda31 Mon Sep 17 00:00:00 2001 From: kevinpollet Date: Wed, 20 Oct 2010 16:30:23 +0200 Subject: [PATCH 5/8] HV-391 Review test assertions for PastValidatorForDate. --- .../test/constraints/impl/PastValidatorForDateTest.java | 1 - 1 file changed, 1 deletion(-) diff --git a/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/PastValidatorForDateTest.java b/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/PastValidatorForDateTest.java index 0883bb0ecb..b99d33d284 100644 --- a/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/PastValidatorForDateTest.java +++ b/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/PastValidatorForDateTest.java @@ -40,7 +40,6 @@ public void testIsValid() { Date pastDate = getPastDate(); assertTrue( constraint.isValid( null, null ) ); assertTrue( constraint.isValid( pastDate, null ) ); - assertFalse( constraint.isValid( new Date(), null ) ); assertFalse( constraint.isValid( futureDate, null ) ); } From cac1cce98fe49a0f35a59aab62cc2184bf8f758a Mon Sep 17 00:00:00 2001 From: kevinpollet Date: Wed, 20 Oct 2010 16:31:49 +0200 Subject: [PATCH 6/8] HV-391 Review test assertions for FutureValidatorForDate. --- .../test/constraints/impl/FutureValidatorForDateTest.java | 1 - 1 file changed, 1 deletion(-) diff --git a/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/FutureValidatorForDateTest.java b/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/FutureValidatorForDateTest.java index 726ec77be0..efebfd8dca 100644 --- a/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/FutureValidatorForDateTest.java +++ b/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/FutureValidatorForDateTest.java @@ -40,7 +40,6 @@ public void testIsValid() { Date pastDate = getPastDate(); assertTrue( constraint.isValid( null, null ) ); assertTrue( constraint.isValid( futureDate, null ) ); - assertFalse( constraint.isValid( new Date(), null ) ); assertFalse( constraint.isValid( pastDate, null ) ); } From 35f34a9dc533f8a7501466e0a122d85b0df962dd Mon Sep 17 00:00:00 2001 From: kevinpollet Date: Wed, 20 Oct 2010 16:37:28 +0200 Subject: [PATCH 7/8] HV-391 Review tests assertions for PastValidatorForAbstractInstant. --- .../constraints/impl/PastValidatorForAbstractInstantTest.java | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/PastValidatorForAbstractInstantTest.java b/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/PastValidatorForAbstractInstantTest.java index bdc55df0cc..f902dc4e62 100644 --- a/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/PastValidatorForAbstractInstantTest.java +++ b/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/PastValidatorForAbstractInstantTest.java @@ -45,7 +45,6 @@ public void testIsValidForInstant() { Assert.assertTrue( validator.isValid( null, null ) ); Assert.assertTrue( validator.isValid( past, null ) ); - Assert.assertFalse( validator.isValid( new DateTime(), null ) ); Assert.assertFalse( validator.isValid( future, null ) ); } @@ -56,7 +55,6 @@ public void testIsValidForDateTime() { Assert.assertTrue( validator.isValid( null, null ) ); Assert.assertTrue( validator.isValid( past, null ) ); - Assert.assertFalse( validator.isValid( new DateTime(), null ) ); Assert.assertFalse( validator.isValid( future, null ) ); } @@ -67,7 +65,6 @@ public void testIsValidForDateMidnight() { Assert.assertTrue( validator.isValid( null, null ) ); Assert.assertTrue( validator.isValid( past, null ) ); - Assert.assertTrue( validator.isValid( new DateMidnight(), null ) ); Assert.assertFalse( validator.isValid( future, null ) ); } @@ -81,7 +78,6 @@ public void testIsValidForMutableDateTime() { Assert.assertTrue( validator.isValid( null, null ) ); Assert.assertTrue( validator.isValid( past, null ) ); - Assert.assertFalse( validator.isValid( new MutableDateTime(), null ) ); Assert.assertFalse( validator.isValid( future, null ) ); } } From 899f93d0df886315723ab943c50fe88cec1bccb6 Mon Sep 17 00:00:00 2001 From: kevinpollet Date: Wed, 20 Oct 2010 16:39:13 +0200 Subject: [PATCH 8/8] HV-391 Review tests assertions for FutureValidatorForAbstractInstant. --- .../impl/FutureValidatorForAbstractInstantTest.java | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/FutureValidatorForAbstractInstantTest.java b/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/FutureValidatorForAbstractInstantTest.java index 7498809e4a..71901eb753 100644 --- a/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/FutureValidatorForAbstractInstantTest.java +++ b/hibernate-validator/src/test/java/org/hibernate/validator/test/constraints/impl/FutureValidatorForAbstractInstantTest.java @@ -45,7 +45,6 @@ public void testIsValidForInstant() { Assert.assertTrue( validator.isValid( null, null ) ); Assert.assertTrue( validator.isValid( future, null ) ); - Assert.assertFalse( validator.isValid( new DateTime(), null ) ); Assert.assertFalse( validator.isValid( past, null ) ); } @@ -56,7 +55,6 @@ public void testIsValidForDateTime() { Assert.assertTrue( validator.isValid( null, null ) ); Assert.assertTrue( validator.isValid( future, null ) ); - Assert.assertFalse( validator.isValid( new DateTime(), null ) ); Assert.assertFalse( validator.isValid( past, null ) ); } @@ -67,7 +65,6 @@ public void testIsValidForDateMidnight() { Assert.assertTrue( validator.isValid( null, null ) ); Assert.assertTrue( validator.isValid( future, null ) ); - Assert.assertFalse( validator.isValid( new DateMidnight(), null ) ); Assert.assertFalse( validator.isValid( past, null ) ); } @@ -81,7 +78,6 @@ public void testIsValidForMutableDateTime() { Assert.assertTrue( validator.isValid( null, null ) ); Assert.assertTrue( validator.isValid( future, null ) ); - Assert.assertFalse( validator.isValid( new MutableDateTime(), null ) ); Assert.assertFalse( validator.isValid( past, null ) ); } }