Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HV-1756 Fix variable names in the newly added translations #1069

Merged
merged 3 commits into from Jan 31, 2020
Merged

HV-1756 Fix variable names in the newly added translations #1069

merged 3 commits into from Jan 31, 2020

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jan 30, 2020

@gsmet
Copy link
Member Author

gsmet commented Jan 30, 2020

@yrodiere I know it's not the most interesting PR but could you have a look?

I think I will probably release something tomorrow (so today when you read these lines) as it's quite bad.

yrodiere
yrodiere approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I did a quick check for other files as well using a regexp, and it looks like you caught them all.

@gsmet gsmet merged commit 3cc3d5c into hibernate:master Jan 31, 2020
@gsmet
Copy link
Member Author

gsmet commented Jan 31, 2020

Thanks! An automated test spotted a couple more issues. It should be all fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrodiere yrodiere yrodiere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gsmet @yrodiere