Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

HV-481 #107

Merged
merged 22 commits into from Mar 5, 2012

Conversation

Projects
None yet
3 participants
Owner

hferentschik commented Mar 2, 2012

Trying to wrap this up. After discussion via email I renamed the log method which return an exception to getXYZException().

For now I moved the log messages for ValueFormatterMessageInterpolator back into the main Log interface. Using the inner class approach you cannot make the class private and the generated class will be public either way. It is a really a tradeoff decision. I think for simplicity reasons we just go with what we have and maybe revisit it later.

Member

kevinpollet commented Mar 2, 2012

It seems you haven't used the last version of my branch rebased on master (containing the changes for HV-550).

@kevinpollet kevinpollet commented on the diff Mar 2, 2012

...bernate/validator/internal/util/logging/Messages.java
@@ -0,0 +1,62 @@
@kevinpollet

kevinpollet Mar 2, 2012

Member

I think the license header is missing!

Member

kevinpollet commented Mar 2, 2012

Looks good!!

Owner

hferentschik commented Mar 2, 2012

It seems you haven't used the last version of my branch rebased on master (containing the changes for HV-550).

Bugger. I forgot to rebase. One sec ...

kevinpollet and others added some commits Jan 18, 2012

@kevinpollet @hferentschik kevinpollet + hferentschik HV-481 Add JBoss logging dependency and configure annotation processo…
…r in parent pom
dcf6515
@kevinpollet @hferentschik kevinpollet + hferentschik Move jsoup dependency to optional section e4474d9
@kevinpollet @hferentschik kevinpollet + hferentschik HV-481 Add JBoss logging dependency and enable annotation processor i…
…n HV pom
ce820b7
@kevinpollet @hferentschik kevinpollet + hferentschik Add final keyword to utility classes 2868596
@kevinpollet @hferentschik kevinpollet + hferentschik HV-481 Workaround for compiler bug c6c66bc
@kevinpollet @hferentschik kevinpollet + hferentschik HV-481 Create a logging package 071f985
@kevinpollet @hferentschik kevinpollet + hferentschik HV-481 Migrate to JBoss logging 0451243
@kevinpollet @hferentschik kevinpollet + hferentschik HV-481 Use JBoss logging logger as an exception factory 7f645c3
@kevinpollet @hferentschik kevinpollet + hferentschik HV-481 Modify assembly to include JBoss logging dependency cc7a806
@kevinpollet @hferentschik kevinpollet + hferentschik HV-481 Update maven-bundle-plugin configuration and documentation 7ae172b
@kevinpollet @hferentschik kevinpollet + hferentschik HV-481 Fix failing tests 0c4748e
@kevinpollet @hferentschik kevinpollet + hferentschik HV-481 Disable JBoss logging annotation processor on tests compilation f3019bc
@kevinpollet @hferentschik kevinpollet + hferentschik HV-481 Modify where JBoss logging classes are generated f4fcdb5
@kevinpollet @hferentschik kevinpollet + hferentschik HV-481 Modify where JAXB classes are generated 4aa7e32
@kevinpollet @hferentschik kevinpollet + hferentschik HV-481 Remove import of javax.script.ScriptException in Log class 3fa3077
@kevinpollet @hferentschik kevinpollet + hferentschik HV-481 Prefix each method which creates an exception with throw 563cbd7
@kevinpollet @hferentschik kevinpollet + hferentschik HV-481 Move Contracts class exceptions to the Log exception factory 219a0b4
@hferentschik hferentschik HV-481 Using a message bundle (@MessageBundle) for i18n messages 5f0fe31
@hferentschik hferentschik HV-481 Removing use of org.hibernate.validator.internal.util.logging.…
…Log in public classes
9373be7
@hferentschik hferentschik HV-481 Renaming exception returning methods to getXYZException()
Also removing the inner class from ValueFormatterMessageInterpolator. It cannot be made private.
7052808
@hferentschik hferentschik HV-481 Adding missing license header aeb586c
Owner

hferentschik commented Mar 2, 2012

here we go :-)

Member

kevinpollet commented Mar 2, 2012

Are you sure? ;-)

Owner

hferentschik commented Mar 2, 2012

@kevinpollet did you actually pull and try to build locally? I am having problems with the distribution module atm. It keeps running out of memory. Not sure whether that is just me right now

Owner

hferentschik commented Mar 2, 2012

hmmm, back on master the full build including the dist works. Something in this change set seems to upset the assembly plugin

Member

kevinpollet commented Mar 2, 2012

Hmm, works fine for me!

Owner

hferentschik commented Mar 2, 2012

Hmm, works fine for me!

Fair enough then

Owner

hferentschik commented Mar 2, 2012

Turns out I had to set an explicit value for the max perm size in my MAVEN_OPTS

@hferentschik hferentschik merged commit 46d21ef into hibernate:master Mar 5, 2012

Owner

gunnarmorling commented Mar 6, 2012

It is a really a tradeoff decision. I think for simplicity reasons we just go with what we have and maybe revisit it later.

I've created HV-560 for this.

Owner

hferentschik commented Mar 6, 2012

I've created HV-560 for this.

Cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment