Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

HV-481 #107

Merged
merged 22 commits into from

3 participants

Hardy Ferentschik Kevin Pollet Gunnar Morling
Hardy Ferentschik
Owner

Trying to wrap this up. After discussion via email I renamed the log method which return an exception to getXYZException().

For now I moved the log messages for ValueFormatterMessageInterpolator back into the main Log interface. Using the inner class approach you cannot make the class private and the generated class will be public either way. It is a really a tradeoff decision. I think for simplicity reasons we just go with what we have and maybe revisit it later.

Kevin Pollet
Collaborator

It seems you haven't used the last version of my branch rebased on master (containing the changes for HV-550).

Kevin Pollet kevinpollet commented on the diff
...bernate/validator/internal/util/logging/Messages.java
@@ -0,0 +1,62 @@
Kevin Pollet Collaborator

I think the license header is missing!

Hardy Ferentschik Owner

Ups ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Kevin Pollet
Collaborator

Looks good!!

Hardy Ferentschik
Owner

It seems you haven't used the last version of my branch rebased on master (containing the changes for HV-550).

Bugger. I forgot to rebase. One sec ...

kevinpollet and others added some commits
Kevin Pollet kevinpollet HV-481 Add JBoss logging dependency and configure annotation processo…
…r in parent pom
dcf6515
Kevin Pollet kevinpollet Move jsoup dependency to optional section e4474d9
Kevin Pollet kevinpollet HV-481 Add JBoss logging dependency and enable annotation processor i…
…n HV pom
ce820b7
Kevin Pollet kevinpollet Add final keyword to utility classes 2868596
Kevin Pollet kevinpollet HV-481 Workaround for compiler bug c6c66bc
Kevin Pollet kevinpollet HV-481 Create a logging package 071f985
Kevin Pollet kevinpollet HV-481 Migrate to JBoss logging 0451243
Kevin Pollet kevinpollet HV-481 Use JBoss logging logger as an exception factory 7f645c3
Kevin Pollet kevinpollet HV-481 Modify assembly to include JBoss logging dependency cc7a806
Kevin Pollet kevinpollet HV-481 Update maven-bundle-plugin configuration and documentation 7ae172b
Kevin Pollet kevinpollet HV-481 Fix failing tests 0c4748e
Kevin Pollet kevinpollet HV-481 Disable JBoss logging annotation processor on tests compilation f3019bc
Kevin Pollet kevinpollet HV-481 Modify where JBoss logging classes are generated f4fcdb5
Kevin Pollet kevinpollet HV-481 Modify where JAXB classes are generated 4aa7e32
Kevin Pollet kevinpollet HV-481 Remove import of javax.script.ScriptException in Log class 3fa3077
Kevin Pollet kevinpollet HV-481 Prefix each method which creates an exception with throw 563cbd7
Kevin Pollet kevinpollet HV-481 Move Contracts class exceptions to the Log exception factory 219a0b4
Hardy Ferentschik hferentschik HV-481 Using a message bundle (@MessageBundle) for i18n messages 5f0fe31
Hardy Ferentschik hferentschik HV-481 Removing use of org.hibernate.validator.internal.util.logging.…
…Log in public classes
9373be7
Hardy Ferentschik hferentschik HV-481 Renaming exception returning methods to getXYZException()
Also removing the inner class from ValueFormatterMessageInterpolator. It cannot be made private.
7052808
Hardy Ferentschik hferentschik HV-481 Adding missing license header aeb586c
Hardy Ferentschik
Owner

here we go :-)

Kevin Pollet
Collaborator

Are you sure? ;-)

Hardy Ferentschik
Owner

@kevinpollet did you actually pull and try to build locally? I am having problems with the distribution module atm. It keeps running out of memory. Not sure whether that is just me right now

Hardy Ferentschik
Owner

hmmm, back on master the full build including the dist works. Something in this change set seems to upset the assembly plugin

Kevin Pollet
Collaborator

Hmm, works fine for me!

Hardy Ferentschik
Owner

Hmm, works fine for me!

Fair enough then

Hardy Ferentschik
Owner

Turns out I had to set an explicit value for the max perm size in my MAVEN_OPTS

Hardy Ferentschik hferentschik merged commit 46d21ef into from
Gunnar Morling

It is a really a tradeoff decision. I think for simplicity reasons we just go with what we have and maybe revisit it later.

I've created HV-560 for this.

Hardy Ferentschik
Owner

I've created HV-560 for this.

Cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 2, 2012
  1. Kevin Pollet Hardy Ferentschik

    HV-481 Add JBoss logging dependency and configure annotation processo…

    kevinpollet authored hferentschik committed
    …r in parent pom
  2. Kevin Pollet Hardy Ferentschik

    Move jsoup dependency to optional section

    kevinpollet authored hferentschik committed
  3. Kevin Pollet Hardy Ferentschik
  4. Kevin Pollet Hardy Ferentschik

    Add final keyword to utility classes

    kevinpollet authored hferentschik committed
  5. Kevin Pollet Hardy Ferentschik
  6. Kevin Pollet Hardy Ferentschik

    HV-481 Create a logging package

    kevinpollet authored hferentschik committed
  7. Kevin Pollet Hardy Ferentschik

    HV-481 Migrate to JBoss logging

    kevinpollet authored hferentschik committed
  8. Kevin Pollet Hardy Ferentschik
  9. Kevin Pollet Hardy Ferentschik
  10. Kevin Pollet Hardy Ferentschik
  11. Kevin Pollet Hardy Ferentschik

    HV-481 Fix failing tests

    kevinpollet authored hferentschik committed
  12. Kevin Pollet Hardy Ferentschik
  13. Kevin Pollet Hardy Ferentschik
  14. Kevin Pollet Hardy Ferentschik

    HV-481 Modify where JAXB classes are generated

    kevinpollet authored hferentschik committed
  15. Kevin Pollet Hardy Ferentschik
  16. Kevin Pollet Hardy Ferentschik
  17. Kevin Pollet Hardy Ferentschik
  18. Hardy Ferentschik
  19. Hardy Ferentschik
  20. Hardy Ferentschik

    HV-481 Renaming exception returning methods to getXYZException()

    hferentschik authored
    Also removing the inner class from ValueFormatterMessageInterpolator. It cannot be made private.
  21. Hardy Ferentschik
  22. Hardy Ferentschik
Something went wrong with that request. Please try again.