HV-436 (The annotation processor should check @GroupSequenceProvider) #40

Merged
12 commits merged into from Mar 13, 2011

Conversation

Projects
None yet
2 participants
Member

kevinpollet commented Mar 12, 2011

No description provided.

Owner

gunnarmorling commented Mar 13, 2011

The change looks really good. But could you perform a rebase to head first, please? Master is several commits ahead. Thanks.

+ return null;
+ }
+
+ List<? extends TypeMirror> superTypes = typeUtils.directSupertypes( declaredType );
@gunnarmorling

gunnarmorling Mar 13, 2011

Owner

Good thinking on considering super types here. That's not the case when retrieving the type from validator implementations right now, though I think very rarely someone would work with inheritance when implementing a validator.

@kevinpollet

kevinpollet Mar 13, 2011

Member

Thanks :)
I also think use of inheritance for implementing a provider will be used very rarely. Such case might occur it's why I think they have to be treated.

Member

kevinpollet commented Mar 13, 2011

Sure, this can be done without closing the pull request ?

Owner

gunnarmorling commented Mar 13, 2011

Hmmm, I hope that after rebasing you are able to modify the commits of this pull request. I haven't done it myself though. If it's not possible just create a new request.

Member

kevinpollet commented Mar 13, 2011

I think it's good

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment