Skip to content

HV-1459 HV-1460 Build improvements #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2017
Merged

HV-1459 HV-1460 Build improvements #831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb8b259
HV-1460 Don't use prerequisite for the minimal version of Maven
gsmet Aug 3, 2017
525409a
HV-1459 Add a sigtest profile to make running the sigtest test easier
gsmet Aug 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions engine/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,5 +386,57 @@
</plugins>
</build>
</profile>
<profile>
<id>sigtest</id>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
<execution>
<id>copy-tck-bv-api-signature-file</id>
<phase>generate-test-sources</phase>
<goals>
<goal>unpack</goal>
</goals>
<configuration>
<artifactItems>
<artifactItem>
<groupId>org.hibernate.beanvalidation.tck</groupId>
<artifactId>beanvalidation-tck-tests</artifactId>
<version>${tck.version}</version>
<type>jar</type>
<overWrite>true</overWrite>
</artifactItem>
</artifactItems>
<!-- We just need the signature file and nothing else -->
<includes>**/*.sig</includes>
<outputDirectory>${project.build.directory}/api-signature</outputDirectory>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.netbeans.tools</groupId>
<artifactId>sigtest-maven-plugin</artifactId>
<executions>
<execution>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
<configuration>
<packages>javax.validation,javax.validation.bootstrap,javax.validation.constraints,
javax.validation.constraintvalidation,javax.validation.executable,javax.validation.groups,
javax.validation.metadata,javax.validation.spi,javax.validation.valueextraction
</packages>
<sigfile>${project.build.directory}/api-signature/validation-api-java8.sig</sigfile>
</configuration>
</plugin>
</plugins>
</build>
</profile>
</profiles>
</project>
13 changes: 8 additions & 5 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@
<maven.javadoc.skip>true</maven.javadoc.skip>

<bv.api.version>2.0.0.Final</bv.api.version>
<tck.version>2.0.0.Final</tck.version>

<!-- Version to be used as baseline for API/SPI change reports -->
<previous.stable>5.4.1.Final</previous.stable>

Expand Down Expand Up @@ -209,10 +211,6 @@
<hibernate-validator-parent.path>.</hibernate-validator-parent.path>
</properties>

<prerequisites>
<maven>3.3.1</maven>
</prerequisites>

<dependencyManagement>
<dependencies>
<dependency>
Expand Down Expand Up @@ -432,7 +430,7 @@
<version>[1.8.0-20,)</version>
</requireJavaVersion>
<requireMavenVersion>
<version>3.0.3</version>
<version>3.3.1</version>
</requireMavenVersion>
</rules>
</configuration>
Expand Down Expand Up @@ -896,6 +894,11 @@
</dependency>
</dependencies>
</plugin>
<plugin>
<groupId>org.netbeans.tools</groupId>
<artifactId>sigtest-maven-plugin</artifactId>
<version>1.0</version>
</plugin>
<!--This plugin's configuration is used to store Eclipse m2e settings only. It has no influence on the Maven build itself.-->
<plugin>
<groupId>org.eclipse.m2e</groupId>
Expand Down
1 change: 0 additions & 1 deletion tck-runner/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
<description>Aggregates dependencies and runs the JSR-380 TCK</description>

<properties>
<tck.version>2.0.0.Final</tck.version>
<tck.suite.file>${project.build.directory}/dependency/beanvalidation-tck-tests-suite.xml</tck.suite.file>
<wildfly.target-dir>${project.build.directory}/wildfly-${wildfly.version}</wildfly.target-dir>
<validation.provider>org.hibernate.validator.HibernateValidator</validation.provider>
Expand Down