From 3b733bae332b74d820d6ad4c1509f86843b0c90f Mon Sep 17 00:00:00 2001 From: Benjamin Fry Date: Fri, 9 Feb 2024 18:23:26 -0800 Subject: [PATCH] fix tests that were not being run --- crates/proto/src/serialize/binary/decoder.rs | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/crates/proto/src/serialize/binary/decoder.rs b/crates/proto/src/serialize/binary/decoder.rs index 1437799333..466e0dc3e5 100644 --- a/crates/proto/src/serialize/binary/decoder.rs +++ b/crates/proto/src/serialize/binary/decoder.rs @@ -245,7 +245,7 @@ impl<'a> BinDecoder<'a> { } } -#[cfg(tests)] +#[cfg(test)] mod tests { use super::*; @@ -255,13 +255,13 @@ mod tests { let mut decoder = BinDecoder::new(deadbeef); let read = decoder.read_slice(4).expect("failed to read dead"); - assert_eq!(read, "dead"); + assert_eq!(&read.unverified(), b"dead"); let read = decoder.read_slice(2).expect("failed to read be"); - assert_eq!(read, "be"); + assert_eq!(&read.unverified(), b"be"); let read = decoder.read_slice(0).expect("failed to read nothing"); - assert_eq!(read, ""); + assert_eq!(&read.unverified(), b""); // this should fail assert!(decoder.read_slice(3).is_err()); @@ -272,20 +272,19 @@ mod tests { let deadbeef = b"deadbeef"; let mut decoder = BinDecoder::new(deadbeef); - decoder.read_slice_from(4).expect("failed to read dead"); + decoder.read_slice(4).expect("failed to read dead"); let read = decoder.slice_from(0).expect("failed to get slice"); - assert_eq!(read, "dead"); + assert_eq!(&read, b"dead"); decoder.read_slice(2).expect("failed to read be"); let read = decoder.slice_from(4).expect("failed to get slice"); - assert_eq!(read, "be"); + assert_eq!(&read, b"be"); decoder.read_slice(0).expect("failed to read nothing"); let read = decoder.slice_from(4).expect("failed to get slice"); - assert_eq!(read, "be"); + assert_eq!(&read, b"be"); // this should fail - assert!(decoder.slice_from(6).is_err()); assert!(decoder.slice_from(10).is_err()); } }