Move RuntimeProvider into proto #2464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
requested review from
bluejekyll,
japaric,
justahero,
listochkin,
marcus0x62 and
pvdrz
as code owners
djc
force-pushed
the
futures
branch
5 times, most recently
from
6ab1dbe to
5071274
Compare
mokeyish
reviewed
Sep 18, 2024
marcus0x62
reviewed
Sep 18, 2024
Collaborator
marcus0x62
left a comment
marcus0x62
left a comment
There was a problem hiding this comment.
The first five commits look good to me as-is.
marcus0x62
reviewed
Sep 18, 2024
marcus0x62
approved these changes
Sep 19, 2024
Member
Author
|
Going to merge this -- @mokeyish happy to take more feedback if this doesn't end up working for your use case! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the code in #2462 I wasn't very happy with the abstractions so I started pulling on some threads. This resulted in moving the
RuntimeProviderfrom the resolver crate to proto, which IMO makes more sense as it doesn't have any dependencies on resolver code. The last commit makes the same change as #2462 but IMO does so in a cleaner way.cc @mokeyish would be happy to get your feedback!