Skip to content

Allow changing URI paths for DNS-over-HTTPS#2470

Merged
djc merged 2 commits intohickory-dns:mainfrom
hch12907:https-path
Sep 27, 2024
Merged

Allow changing URI paths for DNS-over-HTTPS#2470
djc merged 2 commits intohickory-dns:mainfrom
hch12907:https-path

Conversation

@hch12907
Copy link
Contributor

@hch12907 hch12907 commented Sep 21, 2024

This allows for instance ns.example.com/foobar to be used instead of ns.example.com/dns-query.

Fingers crossed I didn't miss anything.

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@djc djc mentioned this pull request Sep 25, 2024
2 tasks
Copy link
Member

@bluejekyll bluejekyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks for applying the change.

@hch12907
Copy link
Contributor Author

Made two changes per the reviews:

  1. Made http_endpoint optional in hickory_client, it's still nonoptional in hickory_proto though
  2. Clarified http_endpoint is applicable to H2 and H3 in server config documentation

@djc djc added this pull request to the merge queue Sep 27, 2024
Merged via the queue into hickory-dns:main with commit cf09c4a Sep 27, 2024
@djc djc mentioned this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants