server: avoid wrapping Arc in Box - #2471
Merged
Merged
Conversation
djc
requested review from
bluejekyll,
japaric,
justahero,
listochkin,
marcus0x62 and
pvdrz
as code owners
September 21, 2024 11:23
djc
force-pushed
the
arc-authorities
branch
from
September 21, 2024 11:29
0ebec7d to
fde5fe4
Compare
djc
force-pushed
the
arc-authorities
branch
from
September 21, 2024 11:41
fde5fe4 to
06c3976
Compare
marcus0x62
approved these changes
Sep 24, 2024
marcus0x62
left a comment
marcus0x62
left a comment
Collaborator
There was a problem hiding this comment.
This looks like a good change to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this pre-existing issue while reviewing #2161. There doesn't seem to be a need to wrap
ArcinBox, since the former already includes a heap allocation and can support trait objects directly.