Add resolver/recursor configuration to avoid udp ports#2487
Merged
djc merged 6 commits intohickory-dns:mainfrom Oct 4, 2024
Merged
Add resolver/recursor configuration to avoid udp ports#2487djc merged 6 commits intohickory-dns:mainfrom
djc merged 6 commits intohickory-dns:mainfrom
Conversation
divergentdave
requested review from
bluejekyll,
djc,
japaric,
justahero,
listochkin,
marcus0x62 and
pvdrz
as code owners
divergentdave
force-pushed
the
david/avoid-udp-ports
branch
from
c3e23b5 to
657472f
Compare
divergentdave
force-pushed
the
david/avoid-udp-ports
branch
from
657472f to
445eeee
Compare
Member
|
Thanks! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #1722 for UDP sockets by adding configuration options to avoid binding to a list of local UDP ports. I added a builder for
UdpClientStreamto clean up the existing constructors, and add the ability to pass on this new configuration. (note that two of the existing constructors were identical save for argument order) I put the list of ports to avoid in anArcfromResolverOptsand onward, to avoid cloningHashSets after startup.I manually tested this by adding a bias to the random port selection and extra logging statements, and confirming that the new rejection sampling loop kicked in.