Kill the sync Resolver#2515
Merged
Merged
Conversation
djc
force-pushed
the
no-sync-resolver
branch
2 times, most recently
from
October 18, 2024 10:53
06e963d to
3882744
Compare
bluejekyll
approved these changes
Oct 19, 2024
bluejekyll
left a comment
bluejekyll
left a comment
Member
There was a problem hiding this comment.
I'm good with this. Only question I have is if we should have an example about how to use this in a non-async context, i.e. create tokio, call it with a blocking call, etc. Thoughts?
Member
Author
That problem is in no way specific to Hickory, so I don't think it should be on our documentation to explain this. There's enough surface area in DNS/our API to focus our attention on... |
djc
enabled auto-merge
October 19, 2024 21:17
Member
Author
|
(Happy to follow up if you disagree with my response to your comments.) |
Member
|
no, they're reasonable. We can tackle some of it in external docs. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 19, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 19, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 19, 2024
This was referenced Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.