Conversation
djc
requested review from
bluejekyll,
japaric,
justahero,
listochkin,
marcus0x62 and
pvdrz
as code owners
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of integrating support for aws-lc-rs (as a ring alternative) and untangling the dependency on OpenSSL in ring signing tests, I've started cleaning up the
KeyPairAPI. As a starting point, I've moved all the API that was actually only dependent on the public key to thePublicKeytrait, which seems like a more obvious way to expose the API.It seems like the abstraction originally tried to leverage openssl traits like
HasPublicandPrivate, but (a) it makes very little sense to have aKeyPairtype that does not have access to the private key and (b) we would definitely prefer for the high-level API not to depend on OpenSSL.