ci: don't build benchmarks, only check them#2542
Merged
Merged
Conversation
marcus0x62
approved these changes
Oct 30, 2024
Member
Author
|
This took the build-bench job from 5m 51s to 1m 5s, bringing the total for "past-future (nightly)" down from 9m 6s to 4m 21s. |
Member
Author
|
Full CI cycle time seems to be down about 2.5m, so that seems like a nice quick win. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI currently takes about 17 minutes for a full run, which feels long. The long pole appears to be the nightly job which builds benchmarks (but doesn't run them) in release mode. The goal here should be to make sure that they compile, so instead of running
cargo bench --no-runwe can runcargo check --bencheswhich should be substantially faster.