New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate further optimizations of the algorithm #1

Closed
hiddentao opened this Issue Apr 18, 2013 · 3 comments

Comments

Projects
None yet
2 participants
@hiddentao
Owner

hiddentao commented Apr 18, 2013

We don't need to store the current row, just the last value calculated in the current row. Implement this optimization.

@wooorm

This comment has been minimized.

Show comment
Hide comment
@wooorm

wooorm Jul 9, 2014

Just wanted you to know that I've implemented this enhancement in my levenshtein module – It was a bit hard to bend by brain around, but in the end it worked out great. You should implement it too!

wooorm commented Jul 9, 2014

Just wanted you to know that I've implemented this enhancement in my levenshtein module – It was a bit hard to bend by brain around, but in the end it worked out great. You should implement it too!

@hiddentao

This comment has been minimized.

Show comment
Hide comment
@hiddentao

hiddentao Jul 10, 2014

Owner

@wooorm Thanks. I've added in this optimization and imported your benchmark tests (please see the README.md for results).

Owner

hiddentao commented Jul 10, 2014

@wooorm Thanks. I've added in this optimization and imported your benchmark tests (please see the README.md for results).

@hiddentao hiddentao closed this Jul 10, 2014

@wooorm

This comment has been minimized.

Show comment
Hide comment
@wooorm

wooorm Jul 10, 2014

Nice job, although bittersweet: now I have to make my module faster! 👍

wooorm commented Jul 10, 2014

Nice job, although bittersweet: now I have to make my module faster! 👍

@artsy-peril artsy-peril bot referenced this issue Aug 22, 2017

Merged

Autolink artists #1245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment