Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Behavior of: this._cookieOpts.expires = new Date(0); #1

Closed
gbbauto opened this Issue · 1 comment

2 participants

@gbbauto

The behavior that I am observing with a session that has been logged off (by setting this.session = null) is that a new cookie is created with time=0 (back to 1/1/1970). The problem is then all new subsequent cookies are set with an expired cookie with time=0, breaking the desired functionality. I have commented out the line, and the behavior seems better, but I am not sure of original purpose.

@hiddentao
Owner

I got that line from the original module. Looking at https://github.com/koajs/session/blob/master/index.js it seems it's unnecessary. Will promptly remove it. Thanks for spotting this.

@hiddentao hiddentao closed this in 5802d6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.