fix(#125/#126/#127): DatabaseHealthCheck / _BoundQueryExecutor / CORS ヘッダー修正#138
Merged
Conversation
- #125: DatabaseHealthCheck の bare except を exc 付きに変更し、 未文書の 'degraded' ステータスを 'error' に統一してログを記録する - #126: _BoundQueryExecutor の全メソッドに OperationalError → DatabaseConnectionException の変換を追加する - #127: cors_allow_headers のデフォルトをワイルドカードから 明示的なヘッダーリストに変更する Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#125 — DatabaseHealthCheck: bare except + 未文書 'degraded' ステータス
except Exception:→except Exception as exc:に変更しlogger.warningでエラーを記録status="degraded"→status="error"に統一（ドキュメントのok | error契約を守る）#126 —
_BoundQueryExecutor: OperationalError 未処理fetch_all,fetch_one,writeの全メソッドにexcept OperationalError → DatabaseConnectionExceptionを追加SqlAlchemyQueryExecutorと対称な実装に揃える#127 —
cors_allow_headersのワイルドカードデフォルト["*"]→["Content-Type", "Authorization", "X-Api-Key", "X-Request-Id"]に変更allow_originsワイルドカード禁止ポリシーと整合させるTest plan
Closes #125
Closes #126
Closes #127
🤖 Generated with Claude Code