New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObservableArrayでメソッド呼び出し時に発生するイベントのイベント名をchange, changeBeforeに変更し、イベントオブジェクトのisDestructiveフラグを削除 #179

Closed
simdy opened this Issue Mar 8, 2013 · 0 comments

Comments

Projects
None yet
1 participant
@simdy
Member

simdy commented Mar 8, 2013

#170, #178 に伴い、ObservableArrayでイベントが発生する場合、それは内容の変更を伴うメソッドの呼び出しであることが自明となる。

イベントの意味を明確にするため

  • observeBefore -> changeBefore
  • observe -> change

とイベント名を変更する。

また、同時にisDestructiveフラグも同様の理由により削除する。

@ghost ghost assigned simdy Mar 8, 2013

simdy added a commit to hifive-labs/hifivemain that referenced this issue Mar 8, 2013

simdy added a commit to hifive-labs/hifivemain that referenced this issue Mar 8, 2013

@simdy simdy closed this Mar 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment