Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

h5.ui.indicator()を、オブジェクトを第1引数に渡せるようにする #348

Closed
fukudayasuo opened this issue Jun 11, 2014 · 0 comments
Assignees
Labels
Milestone

Comments

@fukudayasuo
Copy link

@fukudayasuo fukudayasuo commented Jun 11, 2014

h5.ui.indicatorは、第1引数にtarget、第2引数にoptionオブジェクトを取る。

これを、第1引数にオブジェクトを指定できるようにし、optionの中でtargetを指定できるようにする。

また、今まで通りの(target, option)のような渡し方も対応する。

// 今までの呼び出し方。この呼び出し方も今まで通り対応する。
h5.ui.indicator(document.body, {
  message: 'loading...'
});

// 以下の指定方法にも対応する
h5.ui.indicator({
  target: document.body,
  message: 'loading...'
});
@fukudayasuo fukudayasuo self-assigned this Jun 12, 2014
fukudayasuo pushed a commit to hifive-labs/hifivemain that referenced this issue Jun 12, 2014
controller.indicatorには、h5.ui.indicatorとの違いを記述するようにしました。
@simdy simdy added the enhancement label Jun 16, 2014
@simdy simdy added this to the v1.1.12 milestone Jun 16, 2014
fukudayasuo pushed a commit to hifive-labs/hifivemain that referenced this issue Jun 16, 2014
@simdy simdy closed this Jun 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.