Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller.dispose()を呼んだ時に、__disposeでプロミスを返してそれが失敗する場合は、Controller.dispose()が返すプロミスも失敗させる #370

Closed
fukudayasuo opened this issue Jun 30, 2014 · 0 comments
Assignees
Labels
Milestone

Comments

@fukudayasuo
Copy link

@fukudayasuo fukudayasuo commented Jun 30, 2014

dispose()は__disposeで返すプロミスが失敗しても、dispose()の返すプロミスは必ず成功するようになっていたが、これを、__dispose()が返すプロミスが失敗した場合はdispose()の返すプロミスも失敗するようにする。

また、この時にlifecycleerrorイベントをあげる。

fukudayasuo pushed a commit to hifive-labs/hifivemain that referenced this issue Jun 30, 2014
__disposeでrejectするプロミスを返した時に、nullifyせず、lifecycleerrorイベントが上がるようにしました。
テストケースを修正しました。
fukudayasuo pushed a commit to hifive-labs/hifivemain that referenced this issue Jul 1, 2014
@simdy simdy added this to the v1.1.12 milestone Jul 1, 2014
@simdy simdy added specchange and removed specchange labels Jul 1, 2014
@simdy simdy closed this Jul 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.