Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormController#setValue() boolean型の値でcheckboxの値を設定できない #538

Closed
mtakeuchi opened this issue Jan 27, 2016 · 0 comments
Closed
Assignees
Labels
Milestone

Comments

@mtakeuchi
Copy link
Contributor

@mtakeuchi mtakeuchi commented Jan 27, 2016

boolean型の値でcheckbox要素の値を更新できない。

(HTML)

<form>
  <input type="checkbox" name="chk1">
</form>

(JS)

var data = {
  chk1: true
}

this.formController.setValue(data);

以下のコードの厳密比較が不要と思われる。
h5.ui.FormController.js l.2178

$(this).prop('checked', $(this).val() === value);
@simdy simdy added the enhancement label Mar 1, 2016
@simdy simdy added this to the v1.2.3 milestone Mar 1, 2016
@simdy simdy self-assigned this Mar 1, 2016
tkmHashi pushed a commit that referenced this issue Jun 27, 2016
boolean型の値でcheckboxの値を設定されることを確認するテストケースを追加。
@simdy simdy closed this Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.