Wrong legend value on series mapping #10005

Activity

1. sebastianbochan commented on Jan 28, 2019

   

   sebastianbochan

   on Jan 28, 2019

   Contributor

   More actions

   Hi @kai2468,
   Thank you for reporting.

   Internal note
   @TorsteinHonsi is it a bug or default functionality? I was not able to find any information about it in docs.
2. KacperMadej

   added

   Type: Bug

   on Mar 3, 2019
3. stale commented on Sep 1, 2020

   

   stalebot

   on Sep 1, 2020

   More actions

   This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!
4. stale

   added

   Status: StaleThis issue hasn't had any activity for a while, and will be auto-closed if no further updates occur.This issue hasn't had any activity for a while, and will be auto-closed if no further updates occur.

   on Sep 1, 2020
5. stale

   closed this as completedon Sep 8, 2020
6. highsoft-bot

   added

   Status: Done

   on Sep 8, 2020
7. kai2468 commented on Jan 27, 2021

   

   kai2468

   on Jan 27, 2021

   ContributorAuthor

   More actions

   Any chance this can get looked at?
8. PaulDalek commented on Jan 28, 2021

   

   PaulDalek

   on Jan 28, 2021

   Contributor

   More actions

   Unstale.
9. PaulDalek

   reopened this on Jan 28, 2021
10. stale

    removed

    Status: StaleThis issue hasn't had any activity for a while, and will be auto-closed if no further updates occur.This issue hasn't had any activity for a while, and will be auto-closed if no further updates occur.

    on Jan 28, 2021
11. highsoft-bot

    removed

    Status: Done

    on Jan 28, 2021
12. PaulDalek commented on Jan 28, 2021

    

    PaulDalek

    on Jan 28, 2021

    Last edited by PaulDalek

    Contributor

    More actions

    Hi @kai2468

    Thank you for contacting us. In short, the 0 indexed value shouldn’t be considered as a series name but setting the label option with 0 makes it possible.

    Internal note
    It comes from the SeriesBuilder’s read function, more precisely from the below piece of code that is responsible for removing index of the x property. Setting any custom parameter with 0 index makes it still considered when looking for an index of a name.

    if (typeof this.name === 'undefined' && builder.readers.length >= 2) {
      columnIndexes = builder.getReferencedColumnIndexes();
      if (columnIndexes.length >= 2) {
        // remove the first one (x col)
        columnIndexes.shift();
        // Sort the remaining
        columnIndexes.sort(function(a, b) {
          return a - b;
        });
        // Now use the lowest index as name column
        this.name = columns[columnIndexes.shift()].name;
      }
    }
    
13. maciejBL commented on Jan 26, 2023

    

    maciejBL

    on Jan 26, 2023

    More actions

    Hi, could we get back to the topic, since this is currently a big blocker in our project.

    I've prepared the jsfiddle demo (https://jsfiddle.net/rs4vLu78/58/) to depict what's the problem, I would expect here to have different labels for series, independently from the seriesMapping contains.

    👍React with 👍1Reacted by Kamil Kubik
14. hubertkozik

    self-assigned this

    on Jan 27, 2023
15. hubertkozik

    added a commit that references this issue on Feb 7, 2023

    Fixed #10005, wrong series name and legend item by using seriesMapping.

    This issue will close once commit f8218b6 is merged into the 'master' branch.

    f8218b6
16. highsoft-bot

    added

    Flow: Review in progress

    on Feb 7, 2023
17. TorsteinHonsi

    closed this as completedin #18455on Feb 8, 2023
18. TorsteinHonsi

    added a commit that references this issue on Feb 8, 2023

    Fixed #10005, wrong series name and legend item by using seriesMapping.

    This issue will close once commit 724334d is merged into the 'master' branch.

    724334d
19. highsoft-bot

    added

    Flow: Done

    and removed

    Flow: Review in progress

    on Feb 8, 2023