Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG renderer - width/height image parameters issue #11756

Closed
Basts opened this issue Aug 23, 2019 · 4 comments · Fixed by #16346
Closed

SVG renderer - width/height image parameters issue #11756

Basts opened this issue Aug 23, 2019 · 4 comments · Fixed by #16346

Comments

@Basts
Copy link
Contributor

Basts commented Aug 23, 2019

In the documentation, we can find information saying that:

The image width. If omitted, it defaults to the image file width.
The image height. If omitted it defaults to the image file height.

Meanwhile omitting these parameters is impossible. It is a documentation mistake or this functionality fails?

Live demo with steps to reproduce

Demo where I tried to set on of those parameters to: undefined, '' - empty string, or even null.

Product version

Highcharts JS v7.1.3 (2019-08-14)

Affected browser(s)

All

@pawelfus
Copy link
Contributor

FYI @TorsteinHonsi

@stale
Copy link

stale bot commented Jun 9, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

@stale stale bot added the Status: Stale This issue hasn't had any activity for a while, and will be auto-closed if no further updates occur. label Jun 9, 2021
@stale stale bot closed this as completed Jun 16, 2021
@raf18seb
Copy link
Contributor

raf18seb commented Aug 6, 2021

+1

@TorsteinHonsi more users are asking about it.
Is it an API bug? If yes, then we could quickly improve the docs

@raf18seb raf18seb reopened this Aug 6, 2021
@stale stale bot removed the Status: Stale This issue hasn't had any activity for a while, and will be auto-closed if no further updates occur. label Aug 6, 2021
@TorsteinHonsi
Copy link
Collaborator

@raf18seb I think it's a bug. It was working in v3. Not a very critical one since it has survived for so long, but it should be easy to fix by applying typechecking on x, y, width and height:

// optional properties
if (arguments.length > 1) {
extend(attribs, {
x: x,
y: y,
width: width,
height: height
});
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

7 participants